added tests to classes for which they were missing, increased branch coverage of some tests, fixed but in LongDivison, issues #3895 #3896 #3897

a-kbd · 2023-02-21T09:18:50Z

this should fix issues #3895 and #3896

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized it.
All filenames are in PascalCase.
All functions and variable names follow Java naming conventions.
All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

src/test/java/com/thealgorithms/strings/MyAtoiTest.java

report.md

src/main/java/com/thealgorithms/maths/LongDivision.java

src/test/java/com/thealgorithms/others/CRCAlgorithmTest.java

siriak

Looks good, thanks!

a-kbd added 6 commits February 21, 2023 09:32

added tests for BinaryTree

b2322ae

added tests for CRCAlgorithm

f1ca008

improved the tests and branch coverage for MyAtoi

2066ef4

added tests and improved branch coverage for LongDivision

d58142c

added check to disallow division by zero

e29c828

fix: fixed bug in BinaryTreeTest, access of data field

e47424e

a-kbd requested review from siriak, yanglbme and debasishbsws as code owners February 21, 2023 09:18

Merge branch 'master' into patch-branch

a41763a

siriak requested changes Feb 24, 2023

View reviewed changes

a-kbd and others added 5 commits March 4, 2023 14:16

fix: fixes changes requested in TheAlgorithms#3897

23b74f8

fix: tests require division by zero to return 0

38ca945

feat: Enhanced Unit Tests

a31517a

fix: changed the CRCAlgorithm tests and added comments

56b2fa5

Merge branch 'master' into patch-branch

f040b86

a-kbd requested a review from siriak March 4, 2023 14:40

siriak approved these changes Mar 5, 2023

View reviewed changes

siriak merged commit dd949e9 into TheAlgorithms:master Mar 5, 2023

siriak mentioned this pull request Mar 24, 2023

[BUG] Division by zero in LongDivision #3896

Closed

Provide feedback