Skip to content

Update CONTRIBUTING.md #3486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 4, 2023
Merged

Update CONTRIBUTING.md #3486

merged 5 commits into from
Jan 4, 2023

Conversation

Abinashbunty
Copy link
Contributor

@Abinashbunty Abinashbunty commented Oct 10, 2022

Modified the content by removing redundant info and styled it.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Modified the content by removing redundant info and styled it.
@Abinashbunty
Copy link
Contributor Author

I had to reopen it because it shows "build Expected - Waiting for status to be reported". And the online references suggested to close and reopen.
This still doesn't work. Can you let me know where it might be going wrong? Thanks! 😄

@Abinashbunty
Copy link
Contributor Author

It is a documentation change. Perhaps that is why no "build" is required.

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 4, 2023
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak requested a review from debasishbsws as a code owner January 4, 2023 08:08
@siriak
Copy link
Member

siriak commented Jan 4, 2023

build GitHub action had some conditions that prevented it from running in your PR. This is fixed now.

@siriak siriak merged commit 9d86348 into TheAlgorithms:master Jan 4, 2023
Copy link
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Abinashbunty
Copy link
Contributor Author

Thanks guys. 👍🏻😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants