Skip to content

Implement A5 Cipher #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 27, 2022
Merged

Implement A5 Cipher #3292

merged 4 commits into from
Sep 27, 2022

Conversation

HHHMHA
Copy link
Contributor

@HHHMHA HHHMHA commented Sep 25, 2022

Added A5 Cipher Algorithm. with a demo and actual real time sound recording encryption.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.

siriak
siriak requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove SoundRecorders, ApplicationProperties, WaveDataUtil (i.e., things not related to A5 cipher)

@HHHMHA
Copy link
Contributor Author

HHHMHA commented Sep 26, 2022

@siriak Done

@HHHMHA HHHMHA requested a review from siriak September 26, 2022 09:15
@siriak siriak enabled auto-merge (squash) September 27, 2022 16:30
siriak
siriak approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit e4eb99f into TheAlgorithms:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HHHMHA @siriak