Skip to content

Adding cocktail shaker sort #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2017
Merged

Adding cocktail shaker sort #258

merged 2 commits into from
Oct 23, 2017

Conversation

bizzome
Copy link

@bizzome bizzome commented Oct 23, 2017

I will start contributing to this repository with my version of cocktail shaker sort...

@bizzome
Copy link
Author

bizzome commented Oct 23, 2017

#96 adding sort algorithm

Copy link
Contributor

@varunu28 varunu28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove the package import
  • Adjust the space in CS comment block

@varunu28 varunu28 merged commit 810fdd6 into TheAlgorithms:master Oct 23, 2017
@bizzome
Copy link
Author

bizzome commented Oct 23, 2017

Changed... @varunu28 Can you please tell me why you request to remove the package import ?

@varunu28
Copy link
Contributor

@MattBizzo Currently we are just keeping it as a repository where someone can refer algorithms. We do have plans to add tests in future. Once we do so we may need to add back the packages but as of now it may be a bit confusing for someone coming to this repo for first time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants