Fix maven link and correct Stack implementation #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since January 15, 2020 Maven Central no longer supports insecure communication over plain HTTP and requires that all requests to the repository are encrypted over HTTPS.
The previous implementation would show unexpected behaviour when using the values returned by pop() and peek(). Generic type was needed but not used in implementation thus leading to redundancy. push() had unnecessary return type.
yanglbme
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit updates a link in build.gradle, since the old one is not supported anymore.
Second commit rewrites Stack.java since it contained major design flaws.