-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[feat/fix/docs]: Improve code to follow CI/repo rules #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat/fix/docs]: Improve code to follow CI/repo rules #903
Conversation
Forgot to split commits per change, apologizes!
05dab77
to
ea230cf
Compare
6c63dfe
to
42819f1
Compare
Please create separate pull-requests. better for maintenance. |
Do you mean, separate pull requests for:
|
separate pull-request for each file would be ideal. but no more than five related files per commit The reason I could not split my previous merge #805 was because of the new addition of automated checks, compilation and other automation tools. Here, there is nothing stopping from being modular in creating atomic fixes and is the right way to go |
I'll do as your request when I have time, thanks. |
These are good fixes, but disorganized and hence an invitation for new issues. |
@kvedala is it OK if I create a PR for each small folder (such as |
that would be better and start with one or two file changes only. |
Description of Change
Add a bit of documentation in various files.
Improve code to use C++ standard libraries, and respect repo rules and CI.
This pull request is still WIP.
I will still make more changes.
Checklist
Notes: Forgot to split commits per change, apologizes.