Skip to content

Corrections to errors in the existing files #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 44 commits into from
Closed

Corrections to errors in the existing files #795

wants to merge 44 commits into from

Conversation

kvedala
Copy link
Collaborator

@kvedala kvedala commented May 26, 2020

Description of Change

There are indeed a lot of corrections because of the errors that already exist in the repository.
This is a major effort to fix all the existing errors in the repository:

  • wrongfully named
  • non-compiling codes
  • cpplint incompatible codes

There are a lot of files that changed and I already have a few auto-check tools that verify the CPPLINT and also compilation on linux, Windows and Mac operating systems. This can be checked here: https://github.com/kvedala/C-Plus-Plus/tree/cmake

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • Sort by alphabetical order
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@kvedala
Copy link
Collaborator Author

kvedala commented May 26, 2020

@cclauss seems like the cpplint check tool is incorrectly linking the files: link
Instead of compiling and linking each file separately, it is incorrectly linking them all together. This is leading to duplicate references to functions like main

subprocess.CalledProcessError: Command '['g++', 'computer_oriented_statistical_methods/Gaussian_elimination.cpp', 'computer_oriented_statistical_methods/bisection_method.cpp', 'computer_oriented_statistical_methods/false-position.cpp', 'computer_oriented_statistical_methods/newton_raphson_method.cpp', 'computer_oriented_statistical_methods/secant_method.cpp', 'computer_oriented_statistical_methods/successive_approximation.cpp', 'math/fibonacci.cpp', 'math/prime_factorization.cpp', 'others/GCD_of_n_numbers.cpp', 'others/fibonacci_fast.cpp', 'others/matrix_exponentiation.cpp', 'others/pascal_triangle.cpp', 'sorting/shell_sort2.cpp']' returned non-zero exit status 1.

@cclauss
Copy link
Member

cclauss commented May 26, 2020

Too many files to review on one pull request. Can someone else please review?

kvedala added 5 commits May 26, 2020 10:16
(cherry picked from commit 614ea8e)
(cherry picked from commit 0ad756f)
(cherry picked from commit 139964d)
(cherry picked from commit d6d328c)
kvedala and others added 6 commits May 26, 2020 10:17
(cherry picked from commit fb3a809)
(cherry picked from commit 4b25222)
(cherry picked from commit dd20bf9)
@kvedala kvedala changed the title Major corrections to files Major corrections to errors in the existing files May 26, 2020
@kvedala kvedala changed the title Major corrections to errors in the existing files Corrections to errors in the existing files May 26, 2020
@kvedala kvedala mentioned this pull request May 26, 2020
8 tasks
@kvedala
Copy link
Collaborator Author

kvedala commented May 26, 2020

Too many files to review on one pull request. Can someone else please review?

There are a lot of existing errors in the repository that need to be fixed.
This is a major initiative to normalizaing these corrections 😓

@kvedala
Copy link
Collaborator Author

kvedala commented Jun 10, 2020

included in #805

@kvedala kvedala closed this Jun 10, 2020
@kvedala kvedala deleted the major-corrections-to-files branch June 10, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants