Skip to content

Update: Implementations Links added in Aliquot_Sum.md #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chetannada
Copy link
Contributor

Added Implementations Links in Aliquot_Sum.md

Description

Closes #{ISSUE_ID}

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing checks pass.
  • No plagiarized, duplicated, or repetitive documentation that has been directly copied from another source.
  • If it's a new explanation, it contains solid, understandable, and accessible information.
  • I have read the whole contributing guidelines and agree to the Code of Conduct.

Screenshots (if any)

Note to reviewers

Added Implementations Links in Aliquot_Sum.md
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the specific implementation links with one link to the TheAlgorithms site for the Aliquot sum. See #190.

@chetannada
Copy link
Contributor Author

Please replace the specific implementation links with one link to the TheAlgorithms site for the Aliquot sum. See #190.

Are you mean to say, i need to remove all implementation link and add only one link to the TheAlgorithms site for the Aliquot sum. For ex: https://the-algorithms.com/algorithm/aliquot-sum

Then what about the below links in website it self?
Aliquot Sum - The Algorithms

It will be replace by one link only after i'll replace to one link right? so it will show the same URL of the website when user will click on this implementation link.

Please confirm. What should i do! Thanks.

@appgurueu
Copy link
Collaborator

Are you mean to say, i need to remove all implementation link and add only one link to the TheAlgorithms site for the Aliquot sum. For ex: https://the-algorithms.com/algorithm/aliquot-sum

Yes.

so it will show the same URL of the website when user will click on this implementation link.

Indeed it will be a link to the same page the user is already on. This is a redundancy problem: The links are (presumably) there for when the explanations are viewed on GitHub, but on the website they are redundant. This is a website issue IMO.

Added Single Implementation Link of `The Algorithms` website in Aliquot_Sum.md
@chetannada
Copy link
Contributor Author

Are you mean to say, i need to remove all implementation link and add only one link to the TheAlgorithms site for the Aliquot sum. For ex: https://the-algorithms.com/algorithm/aliquot-sum

Yes.

so it will show the same URL of the website when user will click on this implementation link.

Indeed it will be a link to the same page the user is already on. This is a redundancy problem: The links are (presumably) there for when the explanations are viewed on GitHub, but on the website they are redundant. This is a website issue IMO.

@appgurueu As per your suggestion, I added single link to the TheAlgorithms site for the Aliquot sum.

appgurueu
appgurueu previously approved these changes Aug 16, 2023
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though you could omit the -Aliquot-Sum

@chetannada
Copy link
Contributor Author

chetannada commented Aug 16, 2023

Though you could omit the -Aliquot-Sum

@appgurueu Yeah, Sure i have omitted -Aliquot-Sum

@chetannada
Copy link
Contributor Author

Hi @vbrazo and @Panquesito7 Please review this PR. Thanks.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@Panquesito7 Panquesito7 merged commit 03e42f6 into TheAlgorithms:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants