fixes #110 #148
fixes #110 #148
Conversation
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
|
|
||
| Given a set of items, each with weight and a value, determine the number of each item included in a collection so that the total weight is less than or equal to the given limit and the total value is as large as possible. | ||
|
|
||
| ##### Greedy method will always provide an optimal solution with fractional knapsack problem. |
There was a problem hiding this comment.
Not supposed to be a heading. Use a different way of emphasis. Please explicitly state that it often finds a suboptimal solution for nonfractional knapsack problems.
|
|
||
| O(1) For iterative approach | ||
| O(1) For recursive approach *if tail call optimization is used*, O(log n) due to recursion call stack, otherwise | ||
| O(nlog n) Worst Case |
There was a problem hiding this comment.
Missing a space. Also only the case if you presort the items (which should definitely be mentioned!). Also note that it can be done in O(n) using medians.
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
My comments were not resolved. |
|
Hey, @Swastyy! If you have time, could you please address @appgurueu's comments in another PR? Let us know if you need any help! Thanks. 😃 |
|
Yeah, I'll do it in another PR. |
fixes #110