Skip to content

Add insertion sort explanation + corrected grammar #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 23, 2021
Merged

Add insertion sort explanation + corrected grammar #147

merged 8 commits into from
Nov 23, 2021

Conversation

Leoriem-code
Copy link
Contributor

Like the title said.
I really need to proof-read myself before pushing changes

Panquesito7
Panquesito7 previously approved these changes Nov 12, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@Panquesito7 Panquesito7 added the approved Approved; waiting for merge label Nov 12, 2021
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a section on alternative, more efficient sorting algorithms.

Panquesito7
Panquesito7 previously approved these changes Nov 14, 2021
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a look at the file sizes: There are large GIFs included totaling ~80 MB, which seem to be redundant as there are MP4 files with the same title. Please remove the GIFs and replace them with the MP4s if that's the case.

You should be able to use HTML5 elements to embed videos:

<video controls=""><source src="/path/to/video.mp4" type="video/mp4">Your browser does not support the video tag.</video>

@Leoriem-code
Copy link
Contributor Author

@appgurueu
When I do this, Github doesn't show anything at all.
I tried using the ![]() syntax but it only showed a link to view the video.
That is why I used .gif, it worked.
I will look for a solution, but I think it's best to have a link.

@appgurueu
Copy link
Collaborator

appgurueu commented Nov 14, 2021

@appgurueu When I do this, Github doesn't show anything at all. I tried using the ![]() syntax but it only showed a link to view the video. That is why I used .gif, it worked. I will look for a solution, but I think it's best to have a link.

While GitHub may not support this, I hope the website does? Otherwise we should be able to fix it. The ![]() syntax is for images and can't be used. I agree that links are fine.

@Leoriem-code
Copy link
Contributor Author

I decided to use link rather than trying to fix something that I don't know where to start.

@appgurueu
Copy link
Collaborator

I decided to use link rather than trying to fix something that I don't know where to start.

You deleted other GIF files too. Are you sure that you broke no links in the process?

@Leoriem-code
Copy link
Contributor Author

You're right, I let a typo slip. But now it's okay, I made sure of it

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍
Thank you for your awesome help, @appgurueu! 🎉

@Panquesito7 Panquesito7 merged commit 97d2b8f into TheAlgorithms:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants