-
-
Notifications
You must be signed in to change notification settings - Fork 767
Add insertion sort explanation + corrected grammar #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thank you for your contribution! 😄👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a section on alternative, more efficient sorting algorithms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had a look at the file sizes: There are large GIFs included totaling ~80 MB, which seem to be redundant as there are MP4 files with the same title. Please remove the GIFs and replace them with the MP4s if that's the case.
You should be able to use HTML5 elements to embed videos:
<video controls=""><source src="/path/to/video.mp4" type="video/mp4">Your browser does not support the video tag.</video>
@appgurueu |
While GitHub may not support this, I hope the website does? Otherwise we should be able to fix it. The |
I decided to use link rather than trying to fix something that I don't know where to start. |
You deleted other GIF files too. Are you sure that you broke no links in the process? |
You're right, I let a typo slip. But now it's okay, I made sure of it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thank you for your contribution! 😄👍
Thank you for your awesome help, @appgurueu! 🎉
Like the title said.
I really need to proof-read myself before pushing changes