Skip to content

Issue when scss file includes dashes, not valid pascal case #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weyert opened this issue Sep 26, 2019 · 3 comments · Fixed by #13
Closed

Issue when scss file includes dashes, not valid pascal case #10

weyert opened this issue Sep 26, 2019 · 3 comments · Fixed by #13
Assignees
Labels
bug Something isn't working

Comments

@weyert
Copy link

weyert commented Sep 26, 2019

When you have a file like _react_date_picker.scss it generated an invalid TypeScript interface type. The recommended eslint rules for TypeScript enforce pascal case names for types.

@weyert
Copy link
Author

weyert commented Oct 1, 2019

Hmm, I think the keys are getting from somewhere else e.g. source map or sass itself

@Obi-Dann Obi-Dann self-assigned this Oct 29, 2019
@Obi-Dann Obi-Dann added the bug Something isn't working label Oct 29, 2019
@Obi-Dann
Copy link
Contributor

Thanks for reporting the issue and sorry that it took too long for me to reply - keep missing GitHub notifications. Going to look at the issue this week unless someone else wants to create a PR.

@weyert
Copy link
Author

weyert commented Nov 10, 2019

Thank you very much @DanNSam
Appreciated. This PR also gives me a better understanding how everything works :) I will give it a shot when I am back in the office.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants