Add LeetCode-1 (different approach) and LeetCode-167 in C++ #46

r8025n · 2021-08-06T12:20:57Z

resolves #42

Update with the upstream branch

Add leetcode-1, leetcode-167

Tahanima

Hi @r8025n
Please resolve all the requested changes. Also, change the folder name from 167_TwoSum II to 167_TwoSumII

Tahanima · 2021-08-11T13:15:25Z

Algorithms/Easy/167_TwoSum II/Solution.cpp

+class Solution {
+public:
+    vector<int> twoSum(vector<int>& numbers, int target) {
+        int index1 = 0, index2 = numbers.size()-1, sum;


Change this code to

int index1 = 0, index2 = numbers.size() - 1, sum;

Tahanima · 2021-08-11T13:17:30Z

Algorithms/Easy/167_TwoSum II/Solution.cpp

+public:
+    vector<int> twoSum(vector<int>& numbers, int target) {
+        int index1 = 0, index2 = numbers.size()-1, sum;
+        vector<int> returnVector;


name the variable returnVector to answer and change in other places

Tahanima · 2021-08-11T13:21:11Z

Algorithms/Easy/1_TwoSum/SolutionOne.cpp

+class Solution {
+public:
+    vector<int> twoSum(vector<int>& nums, int target) {
+        vector<pair<int,int>> valueIndexPair;


Change this code to

vector<pair<int, int>> valueIndexPair;

Tahanima · 2021-08-11T13:22:19Z

Algorithms/Easy/1_TwoSum/SolutionOne.cpp

+public:
+    vector<int> twoSum(vector<int>& nums, int target) {
+        vector<pair<int,int>> valueIndexPair;
+	    vector<int> returnVector;	


Change the variable name returnVector to answer and also, change in other places where returnVector has been used. Additionally, fix the indentation.

Tahanima · 2021-08-11T13:22:31Z

Algorithms/Easy/1_TwoSum/SolutionOne.cpp

+    vector<int> twoSum(vector<int>& nums, int target) {
+        vector<pair<int,int>> valueIndexPair;
+	    vector<int> returnVector;	
+	    int index1, index2, sum;


Fix the indentation.

Tahanima · 2021-08-11T13:23:11Z

Algorithms/Easy/1_TwoSum/SolutionOne.cpp

+	    int index1, index2, sum;
+
+        for(int k = 0; k < nums.size(); k++) {
+            valueIndexPair.push_back(pair<int,int>(nums[k], k));


Change this code to

valueIndexPair.push_back(pair<int, int>(nums[k], k));

Tahanima · 2021-08-11T13:23:45Z

Algorithms/Easy/1_TwoSum/SolutionOne.cpp

+
+        sort(valueIndexPair.begin(), valueIndexPair.end());
+
+	    index1 = 0;


Fix indentation

Tahanima · 2021-08-11T13:23:52Z

Algorithms/Easy/1_TwoSum/SolutionOne.cpp

+        sort(valueIndexPair.begin(), valueIndexPair.end());
+
+	    index1 = 0;
+	    index2 = valueIndexPair.size() - 1;


Fix indentation

Tahanima · 2021-08-11T13:24:06Z

Algorithms/Easy/1_TwoSum/SolutionOne.cpp

+        while(index1 < index2) {
+            sum = valueIndexPair[index1].first + valueIndexPair[index2].first;
+
+	        if(sum == target)


Fix indentation

r8025n · 2021-08-13T07:35:16Z

HI,
Thank you for your feedback. I have addressed the requested changes, please review.

Tahanima

Hi @r8025n
Please fix all the indentation issues.

Tahanima · 2021-08-14T18:50:13Z

Algorithms/Easy/1_TwoSum/SolutionOne.cpp

+public:
+    vector<int> twoSum(vector<int>& nums, int target) {
+        vector<pair<int, int>> valueIndexPair;
+	vector<int> answer;	


Need to fix the indentation.

Tahanima · 2021-08-14T18:50:20Z

Algorithms/Easy/1_TwoSum/SolutionOne.cpp

+    vector<int> twoSum(vector<int>& nums, int target) {
+        vector<pair<int, int>> valueIndexPair;
+	vector<int> answer;	
+	int index1, index2, sum;


Need to fix the indentation.

Tahanima · 2021-08-14T18:50:29Z

Algorithms/Easy/1_TwoSum/SolutionOne.cpp

+
+        sort(valueIndexPair.begin(), valueIndexPair.end());
+
+	index1 = 0;


Need to fix the indentation.

Tahanima · 2021-08-14T18:50:40Z

Algorithms/Easy/1_TwoSum/SolutionOne.cpp

+        sort(valueIndexPair.begin(), valueIndexPair.end());
+
+	index1 = 0;
+	index2 = valueIndexPair.size() - 1;


Need to fix the indentation.

Tahanima · 2021-08-14T18:51:06Z

Algorithms/Easy/1_TwoSum/SolutionOne.cpp

+            else
+                index2--;
+        }
+


Need to fix the indentation of the if-else block.

r8025n · 2021-08-15T20:28:27Z

Hi @Tahanima
I am kind of lost now, could you please help me out and point me to the right direction? As your recent requested changes are suggesting there are indentation issues in my code but in my forked repo the code looks okay. What am I missing here?

What I did so far:

Opened a pull request.
Some changes were requested by you.
Addressed the requested changes in my local git repo, updated my repo with the original upstream repo by fetching and merging, then pushed them to my forked repo.
And now as you addressed some indentation issues, as I visited my fork repo they seems fine there!!

So did I miss any steps after pushing the first requested changes to my forked repo?

Tahanima

@r8025n I get your point. No worries. I'll fix the indentation issue (if there is any) after merging. Keep up the good work! 😃

r8025n · 2021-08-18T06:13:25Z

Thank You :)

r8025n and others added 6 commits July 31, 2021 20:56

Add solution to LeetCode 112

c214f5a

Merge remote-tracking branch 'upstream/main'

baab005

Update with the upstream branch

Address requested changes

3d6d053

resolve merge conflict

8454519

Add leetcode 1 (nlogn approach) and leetcode 167

501f684

Merge remote-tracking branch 'upstream/main'

e064a05

Add leetcode-1, leetcode-167

Tahanima requested changes Aug 11, 2021

View reviewed changes

Tahanima assigned r8025n Aug 11, 2021

Tahanima added the needs work Need to make changes label Aug 11, 2021

r8025n and others added 3 commits August 13, 2021 13:08

Merge remote-tracking branch 'upstream/main'

cac0d40

Address requested changes

2aaa517

Fix indentation

42993b8

r8025n requested a review from Tahanima August 13, 2021 07:35

Tahanima requested changes Aug 14, 2021

View reviewed changes

Merge branch 'Tahanima:main' into main

8351c53

Tahanima removed the needs work Need to make changes label Aug 17, 2021

Tahanima approved these changes Aug 17, 2021

View reviewed changes

Tahanima merged commit c67a778 into Tahanima:main Aug 17, 2021


		sort(valueIndexPair.begin(), valueIndexPair.end());

		index1 = 0;

Add LeetCode-1 (different approach) and LeetCode-167 in C++ #46

Add LeetCode-1 (different approach) and LeetCode-167 in C++ #46

Uh oh!

Conversation

r8025n commented Aug 6, 2021

Uh oh!

Tahanima left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

r8025n commented Aug 13, 2021

Uh oh!

Tahanima left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

r8025n commented Aug 15, 2021

Uh oh!

Tahanima left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

r8025n commented Aug 18, 2021

Uh oh!

Uh oh!

Tahanima left a comment •

edited

Loading

Tahanima left a comment •

edited

Loading