ODIN_II: Changes to fix coverity scan errors

The commit addresses several errors
CID 212805:  API usage errors  (PRINTF_ARGS)
Related to verilog-to-routing#1496

Signed-off-by: Georgiy Krylov <[email protected]>

Author: georgkrylov

ODIN_II/SRC/MixingOptimization.cpp

@@ -34,23 +34,20 @@
 
 void MixingOpt::scale_counts() {
     if (this->_blocks_count < 0 || this->_blocks_count == INT_MAX || this->_ratio < 0.0 || this->_ratio > 1.0) {
-        error_message(NETLIST, unknown_location, "%s",
-                      "The parameters for optimization kind:%i are configured incorrectly : count %i, ratio %f\n", this->_kind, this->_blocks_count, this->_ratio);
+        error_message(NETLIST, unknown_location, "The parameters for optimization kind:%i are configured incorrectly : count %i, ratio %f\n", this->_kind, this->_blocks_count, this->_ratio);
         exit(0);
     }
     this->_blocks_count = this->_blocks_count * this->_ratio;
 }
 
 void MixingOpt::assign_weights(netlist_t* /*netlist*/, std::vector<nnode_t*> /*nodes*/) {
     // compute weights for all noted nodes
-    error_message(NETLIST, unknown_location, "%s",
-                  "Assign_weights mixing optimization was called for optimization without specification provided, for kind  %i\n", this->_kind);
+    error_message(NETLIST, unknown_location, "Assign_weights mixing optimization was called for optimization without specification provided, for kind  %i\n", this->_kind);
     exit(0);
 }
 
 void MixingOpt::perform(netlist_t*, std::vector<nnode_t*>&) {
-    error_message(NETLIST, unknown_location, "%s",
-                  "Performing mixing optimization was called for optimization without method provided, for kind  %i\n", this->_kind);
+    error_message(NETLIST, unknown_location, "Performing mixing optimization was called for optimization without method provided, for kind  %i\n", this->_kind);
     exit(0);
 }
 
@@ -63,8 +60,7 @@ MultsOpt::MultsOpt(int _exact)
 MultsOpt::MultsOpt(float ratio)
     : MixingOpt(ratio, MULTIPLY) {
     if (ratio < 0.0 || ratio > 1.0) {
-        error_message(NETLIST, unknown_location, "%s",
-                      "Miltipliers mixing optimization is started with wrong ratio %f\n", ratio);
+        error_message(NETLIST, unknown_location, "Miltipliers mixing optimization is started with wrong ratio %f\n", ratio);
         exit(0);
     }
 
@@ -144,14 +140,12 @@ void MultsOpt::set_blocks_needed(int new_count) {
     this->scale_counts();
 }
 void MixingOpt::instantiate_soft_logic(netlist_t* /*netlist*/, std::vector<nnode_t*> /* nodes*/) {
-    error_message(NETLIST, unknown_location, "%s",
-                  "Performing instantiate_soft_logic was called for optimization without method provided, for kind  %i\n", this->_kind);
+    error_message(NETLIST, unknown_location, "Performing instantiate_soft_logic was called for optimization without method provided, for kind  %i\n", this->_kind);
     exit(0);
 }
 
 void MixingOpt::partial_map_node(nnode_t* /*node*/, short /*traverse_value*/, netlist_t*, /*netlist*/ HardSoftLogicMixer* /*mixer*/) {
-    error_message(NETLIST, unknown_location, "%s",
-                  "Performing partial_map_node was called for optimization without method provided, for kind  %i\n", this->_kind);
+    error_message(NETLIST, unknown_location, "Performing partial_map_node was called for optimization without method provided, for kind  %i\n", this->_kind);
     exit(0);
 }
 

ODIN_II/SRC/include/MixingOptimization.hpp

@@ -138,7 +138,7 @@ class MixingOpt {
      * @brief this variable allows to cache traverse value
      * 
      */
-    short cached_traverse_value;
+    short cached_traverse_value = 0;
 
     // an integer representing the number of required hard blocks
     // that should be estimated and updated through set blocks needed

ODIN_II/SRC/netlist_statistic.cpp

@@ -82,8 +82,7 @@ void mixing_optimization_stats(nnode_t* node, netlist_t* netlist) {
             break;
         }
         default:
-            error_message(NETLIST, unknown_location, "%s",
-                          "Counting weights for mixing optimization for %i: Hard block type is unimplemented", node->type);
+            error_message(NETLIST, unknown_location, "Counting weights for mixing optimization for %i: Hard block type is unimplemented", node->type);
             break;
     }
 }