Skip to content

623: Prevent duplicate Verify or Upload Jobs from running #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mjmeijer
Copy link
Member

@mjmeijer mjmeijer commented Jan 5, 2017

New Verify or Upload commands cancels all existing Verify and Upload on that project.

@jantje
Copy link
Member

jantje commented Jan 6, 2017

@mjmeijer
I have been thinking hard about this pull request and I came to the conclusion not to accept this pull request.

My arguments not to are:
Taking into account slide after "optimization is the root of all evil" https://speakerdeck.com/player/2fa0e3a6cb3a4397a9794943553f42fc?#
Normally you do not click 50 times a build.
If you click 50 times build you probably want 50 builds done.
Adding a optimisation that cancels the previous build may have averse effect and complicates maintenance/testing work.
So as to me there is no need to optimize; so we shouldn't.

It is a hard call because:
I really appreciate your input/work so I hate to refuse this pull request.
In the short time you have been around here you have already contributed good things to the plugin.

Best regards
Jantje

@jantje jantje closed this Jan 6, 2017
@mjmeijer
Copy link
Member Author

mjmeijer commented Jan 7, 2017

We can move the nagging Job up one level so it is still called 50 times. If Jobs are longer running you can now clobber the queue, this should be prevented I think. But it is your call.

@mjmeijer
Copy link
Member Author

mjmeijer commented Jan 7, 2017

My emphasis will be on making it as easy as possible for people to migrate from Arduino IDE and preventing the usual "first time on Eclipse experience"

@jantje
Copy link
Member

jantje commented Jan 7, 2017

My emphasis will be on making it as easy as possible for people to migrate from Arduino IDE and preventing the usual "first time on Eclipse experience"

Sounds like a really good idea. But it is also a good ide to discuss upfront to avoid "frustration".
Is it ok for you if I assign you to issues I think are in this are and the mac related ones.
You can always unassign yourself.
I'm thinking about #80. If I add a "set port to project" you could do the gui (be it in the menu or as a combobox in the toolbar)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants