Support for Linkit SDK

[henols]

Support for Linkit SDK from Mediatek

http://labs.mediatek.com/

[jantje]

This is a concern to me as it overwrites the value of Value and as such due will no longer work.

[henols]

I didn't really like it either it's not looking very nice, but it will work.
I can add a test before trying to replace it with a test before replaceing.

Henrik

Work greener, don't print unless you need to!

On Nov 23, 2014 2:02 PM, "jantje" [email protected] wrote:

In
it.baeyens.arduino.core/src/it/baeyens/arduino/tools/ArduinoHelpers.java:

@@ -640,6 +644,8 @@ private static void setTheEnvironmentVariablesAddthePlatformTxt(IContributedEnvi
if (Var.length == 2) {
String Value = MakeEnvironmentString(Var[1].replace(""{build.path}/syscalls_sam3.c.o"",
""{build.path}/arduino/syscalls_sam3.c.o""));

•       Value = MakeEnvironmentString(Var[1].replace("\"{build.path}/syscalls_mtk.c.o\"",
  

This is a concern to me as it overwrites the value of Value and as such
due will no longer work.

—
Reply to this email directly or view it on GitHub
https://github.com/jantje/arduino-eclipse-plugin/pull/198/files#r20764224
.

[jantje]

The original replace is only needed for the due. As the original replace is no longer in the environment variable I can't understand how due would still work.

[henols]

It's matching on different things syscalls_sam3 and
syscalls_mtk and therefore it will not conflict. But if I add an if
statement it will look more clear.

Work greener, don't print unless you need to!

On Nov 23, 2014 3:14 PM, "jantje" [email protected] wrote:

In
it.baeyens.arduino.core/src/it/baeyens/arduino/tools/ArduinoHelpers.java:

@@ -640,6 +644,8 @@ private static void setTheEnvironmentVariablesAddthePlatformTxt(IContributedEnvi
if (Var.length == 2) {
String Value = MakeEnvironmentString(Var[1].replace(""{build.path}/syscalls_sam3.c.o"",
""{build.path}/arduino/syscalls_sam3.c.o""));

•       Value = MakeEnvironmentString(Var[1].replace("\"{build.path}/syscalls_mtk.c.o\"",
  

The original replace is only needed for the due. As the original replace
is no longer in the environment variable I can't understand how due would
still work.

—
Reply to this email directly or view it on GitHub
https://github.com/jantje/arduino-eclipse-plugin/pull/198/files#r20764675
.

[jantje]

my concern is about
Value = A_function(Var[1]);
Value = Another_function(Var[1]);
Making the first line redundant.
I think replacing your new line with
Value = MakeEnvironmentString(Value.replace(""{build.path}/syscalls_mtk.c.o"",.....
will do the trick

[henols]

Ahhh sorry I didn't see that I will fix it asp.

Work greener, don't print unless you need to!

On Nov 23, 2014 3:34 PM, "jantje" [email protected] wrote:

In
it.baeyens.arduino.core/src/it/baeyens/arduino/tools/ArduinoHelpers.java:

@@ -640,6 +644,8 @@ private static void setTheEnvironmentVariablesAddthePlatformTxt(IContributedEnvi
if (Var.length == 2) {
String Value = MakeEnvironmentString(Var[1].replace(""{build.path}/syscalls_sam3.c.o"",
""{build.path}/arduino/syscalls_sam3.c.o""));

•       Value = MakeEnvironmentString(Var[1].replace("\"{build.path}/syscalls_mtk.c.o\"",
  

my concern is about
Value = A_function(Var[1]);
Value = Another_function(Var[1]);
Making the first line redundant.
I think replacing your new line with
Value =
MakeEnvironmentString(Value.replace(""{build.path}/syscalls_mtk.c.o"",.....
will do the trick

—
Reply to this email directly or view it on GitHub
https://github.com/jantje/arduino-eclipse-plugin/pull/198/files#r20764846
.

[henols]

There are some new new code in there now, have a look.