Skip to content

Theming support #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2014
Merged

Theming support #159

merged 4 commits into from
Jun 29, 2014

Conversation

wimjongman
Copy link
Member

This will add the theming support but will not allow to build against old eclipse versions any more.

jantje added a commit that referenced this pull request Jun 29, 2014
@jantje jantje merged commit ad94da6 into Sloeber:master Jun 29, 2014
@@ -104,7 +104,7 @@
class="it.baeyens.arduino.ui.NewArduinoSketchWizard"
name="%wizard.name"
icon="icons/arduino.png"
finalPerspective ="org.eclipse.cdt.ui.CPerspective"
finalPerspective ="it.baeyens.arduino.application.perspective"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wimjongman
I think this may give problems in the plugin version as (if I'm not mistaken) the arduino perspective is part of the product.
I propose that I'll move the arduino perspective to the core plugin after the mac product issue is fixed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No the application should be included in the update site. I will open a bug and fix it.

#163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants