-
Notifications
You must be signed in to change notification settings - Fork 132
Various fixes #1579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes #1579
Conversation
…able paths in "build_then_launch.sh" (paths are case-sensitive on Linux et al.); Added note about requiring Java 17 to top-level "readme.md"; Cleaned-up and corrected examples in top-level "readme.md".
readme.md
Outdated
|
||
* Build the latest version for the platform you are running on: | ||
|
||
`mvn clean verify -DskipTests=true` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOSDK is best here
The SDK is an option to build a eclipse instance to do java development on sloeber
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great;
Just some minor tweeks.
Thanks
Jantje
readme.md
Outdated
`mvn clean verify -Plinux64,latest,NOSDK -DskipTests=true` | ||
|
||
* Build Eclipse + Sloeber for 32-bit Linux: | ||
`mvn clean verify -Plinux32,latest,NOSDK -DskipTests=true` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
32 bit eclipse doesn't work anymore.
As you are on it. Can you remove these 32 bit references?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. I saw the website pages are also in this repository so I'll remove the chmod
note from the Linux download page as well (can't test that the download page handles tar.gz
correctly though since I don't have PHP installed). I'll add a commit with all the additional stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can leave download links on the web pages to me. The download links to the web pages are based on files and only updated when I make an official release.
I'm currently making a release and though the local build on my system provides a tar file for linux the actions here provide a zip. |
It seems the actions recreates the files |
tar.gz
Fixes issue 1577
Fixes issue 1557
When using
tar.gz
instead ofzip
the Linux file permissions are preserved (i.e.sloeber-ide
,jexec
, andjspawnhelper
are all executable).The download page at http://eclipse.baeyens.it/stable.php?OS=Linux also needs to be updated with the new filename. The text saying to run
chmod
can be removed.build_then_launch.sh
(paths are case-sensitive on Linux et al.)readme.md
This fixes issue 1544
readme.md
Several of the examples had
latest.NOSDK
(with a period) instead oflatest,NOSDK
(with a comma).