Skip to content

Java11 compatible #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 24, 2022
Merged

Java11 compatible #1520

merged 6 commits into from
Nov 24, 2022

Conversation

wimjongman
Copy link
Member

Move all plugins to java 11

@wimjongman wimjongman marked this pull request as draft November 23, 2022 14:06
@jantje
Copy link
Member

jantje commented Nov 24, 2022

I think this pull request is ready to pull.
Can you change the status from draft to ready?

@wimjongman wimjongman marked this pull request as ready for review November 24, 2022 07:44
@wimjongman
Copy link
Member Author

Early start? 🌞

@wimjongman wimjongman merged commit 35ed109 into master Nov 24, 2022
@wimjongman wimjongman deleted the java11-compatible branch November 24, 2022 07:46
@jantje
Copy link
Member

jantje commented Nov 24, 2022

Nope: bed time story ;-)

@jantje
Copy link
Member

jantje commented Nov 26, 2022

There is a problem with this pull request.
When you try to run the product in java11 you will get the error
Caused by: java.lang.UnsupportedClassVersionError: io/sloeber/core/toolchain/ArduinoLanguageProvider has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0
I have been trying for a couple of days to fix this but I failed. so I went back to this branch and I noticed the same issue here.
I tried to fix here and it worked.
I'm bafflegasted but happy that it works so I will create a new pull request.
This is my workspace compiler setting
afbeelding

java11errorlog.log

@jantje
Copy link
Member

jantje commented Nov 26, 2022

I tried to push the changes and now I get
afbeelding
He complains about the actions but I didn't touch those :-(

afbeelding

@jantje
Copy link
Member

jantje commented Nov 26, 2022

So I switched back to the branch I was working on and now it works :-S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants