Skip to content

upgrade to java 8 #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jantje opened this issue Dec 17, 2015 · 8 comments
Closed

upgrade to java 8 #334

jantje opened this issue Dec 17, 2015 · 8 comments
Assignees
Labels
domain: configuration Configuring Sloeber does not work as docummented OS: all status: fixed in 3.0

Comments

@jantje
Copy link
Member

jantje commented Dec 17, 2015

As I needed some java 8 functionality I upgraded to java 8 in the big changes branch.

@jantje jantje added Help wanted If you want to become a active contributor, start looking at this issue. OS: all domain: configuration Configuring Sloeber does not work as docummented labels Dec 17, 2015
@jantje jantje self-assigned this Dec 17, 2015
@jantje
Copy link
Member Author

jantje commented Dec 24, 2015

I seem to be unable to unable to build with maven.
I tried several things but I can't find the solution.
The root cause is a java 8 command. I checked everything ut it looks like all is set is to use java8 but still ...

@wimjongman do you want to take a look?

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.22.0:compile (default-compile) on project it.baeyens.arduino.common: Compilation failure: Compilation failure:
[ERROR] /home/jan/workspaces/eclipse_plugin/ArduinoPluginDevelopment/arduino-eclipse-plugin/it.baeyens.arduino.common/src/it/baeyens/arduino/common/ArduinoInstancePreferences.java:[285]
[ERROR] setGlobalValue(KEY_PRIVATE_LIBRARY_PATHS, String.join("\n", folderName)); //$NON-NLS-1$
[ERROR] ^^^^
[ERROR] The method join(String, String[]) is undefined for the type String
[ERROR] /home/jan/workspaces/eclipse_plugin/ArduinoPluginDevelopment/arduino-eclipse-plugin/it.baeyens.arduino.common/src/it/baeyens/arduino/common/ArduinoInstancePreferences.java:[293]
[ERROR] setGlobalValue(KEY_PRIVATE_HARDWARE_PATHS, String.join("\n", folderName)); //$NON-NLS-1$
[ERROR] ^^^^
[ERROR] The method join(String, String[]) is undefined for the type String
[ERROR] 2 problems (2 errors)
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :it.baeyens.arduino.common
bash-4.1$

@jantje jantje assigned wimjongman and unassigned jantje Dec 24, 2015
@jantje
Copy link
Member Author

jantje commented Dec 24, 2015

FYI the code is in the bigChange branch

@jantje
Copy link
Member Author

jantje commented Dec 24, 2015

After I upgraded the default java on my system to 8 mvn verify works.
Looks like travis is not yet running java 8

@jantje
Copy link
Member Author

jantje commented Dec 24, 2015

Been nosing in the doc of travis and found a way to force oracle java 8
But that gives another error.
Is there incompatibilities between openjdk 8 and oracle 8?

Testing for PID=2085

Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=192m; support was removed in 8.0

PID=2085 still running at 180 seconds

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.22.0:compile (default-compile) on project it.baeyens.arduino.common: Compilation failure: Compilation failure:

[ERROR] /home/travis/build/jantje/arduino-eclipse-plugin/it.baeyens.arduino.common/src/it/baeyens/arduino/common/Common.java:[337]

[ERROR] IResource resource = epart.getEditorInput().getAdapter(IResource.class);

[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[>ERROR] Type mismatch: cannot convert from Object to IResource

[ERROR] 1 problem (1 error)

[ERROR] -> [Help 1]

[ERROR]

@jantje
Copy link
Member Author

jantje commented Dec 25, 2015

Reverted to oracle java 8 and added a cast

@jantje
Copy link
Member Author

jantje commented Dec 25, 2015

The code that causes the oracle java 8 to fail will be replaced by a fix for #324

@jantje jantje assigned jantje and unassigned wimjongman Dec 25, 2015
@jantje jantje added Status: fixed in big change and removed Help wanted If you want to become a active contributor, start looking at this issue. labels Dec 30, 2015
jantje added a commit that referenced this issue Jan 5, 2016
@GHPS
Copy link

GHPS commented Mar 22, 2016

Building the current development version under Kubuntu 14.04 I also got the error
The method join(String, String[]) is undefined for the type String
Installing OpenJDK 8 and activating it solved the problem.

A detailed description can be found here:
http://askubuntu.com/questions/464755/how-to-install-openjdk-8-on-14-04-lts

@jantje
Copy link
Member Author

jantje commented Mar 22, 2016

I found out the hard way there is a problem in ubuntu 14 and java 8
To help people I made this video: https://www.youtube.com/watch?v=AmePMUuv0uk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: configuration Configuring Sloeber does not work as docummented OS: all status: fixed in 3.0
Projects
None yet
Development

No branches or pull requests

3 participants