-
Notifications
You must be signed in to change notification settings - Fork 132
ESP8266 V3.1.1 fails to build #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I tested with the workaround still available. I modifies the code to be more readable and tested without the workaround this time :-(
Workaround: in platform.txt change recipe.hooks.prebuild.2.pattern to recipe.hooks.prebuild.1.pattern |
After fixing the fact that sloeber only picks up pre and post commands starting from 1 things became worse. So the current situation in the nightly is that
Therefore
The nightly works again so I close this issue as fixed in the nightly |
ESP8266 V3.1.1 fails to build
This is caused by
recipe.hooks.prebuild.2.pattern="${runtime.tools.python3.path}/python3" -I "${runtime.tools.mkbuildoptglobals}" "${runtime.ide.path}" ${runtime.ide.version} "${build.path}" "${build.opt.fqfn}" "${globals.h.source.fqfn}" "${commonhfile.fqfn}" ${mkbuildoptglobals.extra_flags}
This because Sloeber assumes the hooks to start from 1 and here it starts from 2.
Note that -as we learned from other issues- the usage of the opt file decreases the user experience due to discovery problems because the discovery command fails due to a missing .opt file (created in the PREBUILD command only executed during build.
The text was updated successfully, but these errors were encountered: