runtime.hardware.path should evaluate to "board platform"

[JAndrassy]

Sloeber, plugin version 4.4.1.202202160121
Eclipse 2020-12 (4.18.0)
Linux Mint

When using customized board definitions in sketchbook's hardware folder, Sloeber evaluates runtime.hardware.path to referenced "core platform", but it should evaluate to "board platform".

The property runtime.platform.path is evaluated OK in Sloeber.

Arduino doc on global properties: https://arduino.github.io/arduino-cli/0.21/platform-specification/#global-predefined-properties

my customized boards definitions as example: https://github.com/jandrassy/my_boards

[jantje]

When using customized board definitions in sketchbook's hardware folder, Sloeber evaluates runtime.hardware.path to referenced "core platform",

Yes it does

arduino-eclipse-plugin/io.sloeber.core/src/io/sloeber/core/api/BoardDescription.java

Line 786 in 2f4e982

allVars.put(ENV_KEY_HARDWARE_PATH, coreHardwarePath.removeLastSegments(1).toOSString());

Arduino doc on global properties: https://arduino.github.io/arduino-cli/0.21/platform-specification/#global-predefined-properties

Seems the documentation has become a bit more clear since I last read it. Seems I should do some refactoring to get the code compliant with https://arduino.github.io/arduino-cli/0.21/platform-specification/#platform-terminology

my customized boards definitions as example: https://github.com/jandrassy/my_boards

Can you describe a case where the build fails due to this issue? I'm considering to add it as a test case. in the regression tests

[JAndrassy]

in my_boards/avr I use my build of arduinoOTA tool (with a timeout parameter). the path is defined in platform.txt with runtime.hardware.path

[jantje]

in my_boards/avr I use my build of arduinoOTA tool (with a timeout parameter). the path is defined in platform.txt with runtime.hardware.path

If this is your description of a case where the build fails due to this issue; I fear I will need a more detailed description.

[JAndrassy]

for example property tools.arduinoOTA.cmd={runtime.hardware.path}/tools/arduinoOTA
in file /home/juraj/Documents/Arduino/hardware/my_boards/avr/platform.txt
for board from /home/juraj/Documents/Arduino/hardware/my_boards/avr/boards.txt
evaluates in Arduino IDE to /home/juraj/Documents/Arduino/hardware/my_boards/tools/arduinoOTA
but in Sloeber it evaluates to /home/juraj/eclipse/arduinoPlugin/packages/arduino/hardware/avr/tools/arduinoOTA

doc:

{runtime.hardware.path}: the absolute path of the hardware folder (i.e. the folder containing the board platform folder)

The "board platform" is the platform that defines the currently selected board (e.g. the platform that contains the board.txt the board is defined in

so by the example the {runtime.hardware.path} should evaluate to /home/juraj/Documents/Arduino/hardware/my_boards

[jantje]

Based on https://arduino.github.io/arduino-cli/0.21/platform-specification/#global-predefined-properties
I would say runtime.hardware.path is the parent of runtime.platform.path

[jantje]

@JAndrassy can you validate the change?

[JAndrassy]

it is OK
(sorry, it took me hours to build and run Sloeber from sources)

[jantje]

sorry, it took me hours to build and run Sloeber from sources

That is not needed as Sloeber supports github actions and these have the artifacts that are the product and the update site

[jantje]

Closing as fixed