Skip to content

Revisit the update site #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wimjongman opened this issue Sep 10, 2021 · 13 comments
Closed

Revisit the update site #1381

wimjongman opened this issue Sep 10, 2021 · 13 comments
Labels
Milestone

Comments

@wimjongman
Copy link
Member

wimjongman commented Sep 10, 2021

Failing update

See #1361 for what people are currently seeing.

The current update site is not self-contained. It means that Sloeber depends on other update sites to be available as well. Since we cannot depend on them, I suggest that we make the update site self-contained meaning that it contains everything that Sloeber needs.

I have been testing with the self-contained repository and it basically does not require anything else but the CDT and the Oscilloscope widget to plot.

Marketplace

Currently, Sloeber has two entries on the marketplace. One for the product and one for the plugin. It is confusing for the user because "what needs to be installed?" Furthermore, both marketplace entries install the same feature, so there is no difference between the two entries.

I suggest dropping the product and add to the plugin entry that we advise the beginner to start with the product download.

@wimjongman
Copy link
Member Author

@jantje +1 for removing the product entry from the marketplace?

@jantje
Copy link
Member

jantje commented Sep 11, 2021

Seems like a plan.

@jantje
Copy link
Member

jantje commented Sep 11, 2021

There were already references to the product download pages on the plugin marketplace page so I simply deleted the product market page.

@jantje
Copy link
Member

jantje commented Sep 11, 2021

I'm not sure whether the self-contained update site is a good thing.
I think we had that in the past and it caused lots of issues to me.
Now that gnu mcu is part of cdt we are only dependent on the following update sites

  • eclipse release
  • nebula
  • optionally babel

This only adds nebula to what a standard internationalized eclipse install should have

I personally think that the problems were amongst others cause by product installs that used the old gnu mcu requiring old CDT which is incompatible with sloeber 4.4 requiring CDT 10 or higher
And outdated update site references in sloeber

@wimjongman
Copy link
Member Author

Yes, this is a nice fix. However, this will not solve the plugins issue. The update sites in the product do not work for the plug-in.

Any problems we had in the past are probably solved with later Tycho and P2 versions.

@jantje
Copy link
Member

jantje commented Sep 12, 2021

The update sites in the product do not work for the plug-in.

I do not understand this

@wimjongman
Copy link
Member Author

People report that the plugin update fails. Not the product update. You have been changing the repositories in the .product file. This has no effect on issue #1361

@jantje
Copy link
Member

jantje commented Sep 12, 2021

I also updated the update site
23c8bf1
Which also contained gnu mcu outdated update site
23c8bf1#diff-1bd341ca9a93db8adedda7fe851eda08d24b7a51cb554aeb4a63ac8b7a94a198L21

@wimjongman
Copy link
Member Author

I see. That makes sense.

@wimjongman
Copy link
Member Author

Update site stays at it is then.

I have changed the Github build. All artifacts of a github build are now saved and can be downloaded.

All products and the update site.

e.g. https://github.com/Sloeber/arduino-eclipse-plugin/actions/runs/1224353006

@jantje
Copy link
Member

jantje commented Sep 13, 2021

I'm considering releasing 4.4.1
This because some serious fixes/improvements have been made and your java inclusion may make transition to 4.4.X lots easier

@jantje
Copy link
Member

jantje commented Sep 13, 2021

@wimjongman
What do you think about releasing 44.1?

@wimjongman
Copy link
Member Author

Yes but we have to make sure that it works first.

wimjongman added a commit that referenced this issue Sep 13, 2021
Adding the github artifacts location to the nightly downloads page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants