Skip to content

Platform.sloeber.txt is not handled the same way as boards.sloeber.txt #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jantje opened this issue Nov 22, 2020 · 3 comments
Closed

Platform.sloeber.txt is not handled the same way as boards.sloeber.txt #1267

jantje opened this issue Nov 22, 2020 · 3 comments

Comments

@jantje
Copy link
Member

jantje commented Nov 22, 2020

platform.sloeber.txt is created at platform install but boards.sloeber.txt is created at each read.
See more details at #1184
@jantje
Copy link
Member Author

jantje commented Nov 22, 2020

My assumption that platform.txt files are processed by txtFile class is wrong .... only boards.txt are processed this way.
Need to think about how to process this.

@jantje
Copy link
Member Author

jantje commented Nov 22, 2020

This turns out to be a real rabbithole.

@jantje jantje changed the title Platform.sloeber.txt is not created the same way as boards.sloeber.txt Platform.sloeber.txt is not handled the same way as boards.sloeber.txt Nov 23, 2020
jantje pushed a commit that referenced this issue Dec 1, 2020
#1267 starting testing boards
941ffff 
I put all txt processing in a seperate package
I put vars in a key value list and add the key value list then to the
build environment variables
This is prep work for making a variable provider
Cleaned up lots of redundant code
Moved more "workarounds" to the workaround class so sloeber.txt files
are nearly 100% ready to be simply read and ready
@jantje jantje mentioned this issue Dec 17, 2020
Closed
@jantje
Copy link
Member Author

jantje commented Dec 31, 2020

This is fixed.
I'm not marking this as fixed in nightly as this is never released

@jantje jantje closed this as completed Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jantje