Skip to content

upload in nightly does not work #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wimjongman opened this issue Nov 14, 2020 · 16 comments
Closed

upload in nightly does not work #1254

wimjongman opened this issue Nov 14, 2020 · 16 comments

Comments

@wimjongman
Copy link
Member

wimjongman commented Nov 14, 2020

I am working on a new projject and I reinstalled sloeber in c:\apps\sloeber

I can't get the sketch to upload, any idea?

Starting upload
Uploading project "blink" with "AVRDUDE"
Starting reset using DTR toggle process -> I see board action
Continuing to use "COM3"
Ending reset

Launching:
Output:
Cannot run program "" (in directory "C:\Users\jongw\workspaces\slbr"): CreateProcess error=87, The parameter is incorrect
failed to upload "L/blink/blink}/Release/blink.hex"

image

@jantje jantje closed this as completed Nov 14, 2020
@jantje jantje reopened this Nov 14, 2020
@Sloeber Sloeber deleted a comment from jantje Nov 14, 2020
@Sloeber Sloeber deleted a comment from jantje Nov 14, 2020
@Sloeber Sloeber deleted a comment from jantje Nov 14, 2020
@wimjongman
Copy link
Member Author

Ok, I was referring to the wrong issue. I removed all unrelated comments and answers.

This is about the upload not working. Is this caused by CDT10 you think?

The first message I see is:

A.tools.avrdude.upload..pattern : not found in the platform.txt file

There is a double point between upload and pattern. Is that a red herring?

@wimjongman
Copy link
Member Author

I assume the platform.txt is refering to pre_processing_platform.txt which is rebuilt one every restart. My file does not conain the menioned key ^^
pre_processing_platform.txt

@jantje
Copy link
Member

jantje commented Nov 14, 2020

you can't use cdt10 with the latest sloeber release on windows
why
pre cdt10 all environment variables were uppercased on windows
post cdt10 no uppercasing happens
cdt has always been case sensitive
as the current final release was pre cdt 10 it assumes cdt uppercases the environment variables

@jantje jantje changed the title Upload is not working the latest sloeber release does not work with cdt10 or later (use the nightly to use cdt10) Nov 14, 2020
@wimjongman
Copy link
Member Author

wimjongman commented Nov 14, 2020

I debugged the program and found a bug in the code below. When the networkPrefix is empty, the key will get two dots and can not be resolved to a value. When the dot is removed, it is resolved.


        if (isNetworkUpload()) {
            networkPrefix = Const.NETWORK_PREFIX;
        }
        String key = Const.A_TOOLS + upLoadTool + DOT + action + DOT + networkPrefix + DOT + Const.PATTERN;

Still this does not solve it completely,

@wimjongman
Copy link
Member Author

wimjongman commented Nov 14, 2020

Launching:  -C -patmega328p -carduino -PCOM3 -b115200 -D -Uflash:w:C:\Users\jongw\workspaces\runtime-arduino.product\sloeber\Release/sloeber.hex:i 
 
Output:

Cannot run program "" (in directory "C:\Users\jongw\workspaces\runtime-arduino.product"): CreateProcess error=87, The parameter is incorrect

What should it put there? "make" or "avrdude"?

@jantje
Copy link
Member

jantje commented Nov 15, 2020

What should it put there? "make" or "avrdude"?

That is defined by the boards.txt/platform.txt

@jantje
Copy link
Member

jantje commented Nov 15, 2020

The DOT problem is indeed a bug but it is a bug in the nightly introduced during the upperCasing removal.
And why I'm reluctant to release

@jantje
Copy link
Member

jantje commented Nov 15, 2020

The DOT is not the only problem. Seems workaround needs a fix to.

jantje pushed a commit that referenced this issue Nov 15, 2020
jantje pushed a commit that referenced this issue Nov 15, 2020
jantje pushed a commit that referenced this issue Nov 15, 2020
This is only graphical
@jantje
Copy link
Member

jantje commented Nov 15, 2020

Works now on my system

@wimjongman
Copy link
Member Author

What should it put there? "make" or "avrdude"?

That is defined by the boards.txt/platform.txt

What is the key for that specific part?

@wimjongman
Copy link
Member Author

Ok, I looked at platform.txt. It contains the following:

tools.avrdude.cmd.path={path}/bin/avrdude
<snip>
tools.avrdude.upload.pattern="{cmd.path}" "-C{config.path}" {upload.verbose} {upload.verify} -p{build.mcu}

It looks to me that "cmd.path" should be "tools.avrdude.cmd.path"

@jantje
Copy link
Member

jantje commented Nov 15, 2020

It looks to me that "cmd.path" should be "tools.avrdude.cmd.path"

yes
That is fixed in 52a3422
There was still a toupper

@jantje
Copy link
Member

jantje commented Nov 15, 2020

sorry should have been 1a25c1b
The other is the cosmetic stuff

@wimjongman
Copy link
Member Author

I'm running with that commit. Do I have to remove everything first?

@jantje
Copy link
Member

jantje commented Nov 15, 2020

please see your whatsapp/mail I'm waiting in video chat for you

@wimjongman
Copy link
Member Author

I'm running with that commit. Do I have to remove everything first?

I removed the arduinoPlugin directory and now it finally uploads.

@jantje jantje changed the title the latest sloeber release does not work with cdt10 or later (use the nightly to use cdt10) upload in nightly does not work Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants