#585 adding the gui part

Italian translation is still needed

Author: jantje

io.sloeber.ui.nl1/OSGI-INF/l10n/bundle_nl.properties

@@ -93,4 +93,5 @@ wizard.folder.import.name= Importeer een map met source code in je gekozen sketc
 wizard.libraries.import.description = Gebruik een wizard om arduino libraries toe te voegen aan je sketch.
 wizard.libraries.import.name = Importeer Arduino libraries in de huidige sketch.
 wizard.new.sketch.description = Maak een nieuwe Arduino sketch.
-wizard.new.sketch.name  = Nieuwe Arduino Sketch
+wizard.new.sketch.name  = Nieuwe Arduino Sketch
+page.preferences.targets.name = Bouw doelen

io.sloeber.ui/OSGI-INF/l10n/bundle.properties

@@ -78,6 +78,7 @@ launch.arduino.label = Arduino Launch
 page.preferences.libraries.name = Library Manager
 page.preferences.platform..name = Platforms and Boards
 page.preferences.third.party.name = Third party index url's
+page.preferences.targets.name = Build targets
 plotter.view.name = Plotter
 serial.monitor.view.name = Serial monitor view
 tab.board.selection.name = Arduino board selection

io.sloeber.ui/plugin.xml

@@ -321,6 +321,12 @@
           id="io.sloeber.eclipse.libraries"
           name="%page.preferences.libraries.name">
     </page>
+    <page
+          category="io.sloeber.eclipse.ArduinoPreferencePage"
+          class="io.sloeber.ui.preferences.TargetSerialDisconnectPage"
+          id="io.sloeber.eclipse.tagets"
+          name="%page.preferences.targets.name">
+    </page>
  </extension>
   <extension
        point="org.eclipse.ui.commands">

io.sloeber.ui/src/io/sloeber/ui/Messages.java

@@ -160,8 +160,11 @@ public class Messages extends NLS {
     public static String ui_workspace_settings;
     public static String ui_enable_bonjour;
 	public static String ui_put_in_version_control;
+	public static String target_maintain;
+	public static String Add_Targets_To_force_serial_disconnect_when_run;
 
     public static String yes;
+
     static {
         // initialize resource bundle
         NLS.initializeMessages(BUNDLE_NAME, Messages.class);

io.sloeber.ui/src/io/sloeber/ui/messages.properties

@@ -132,3 +132,5 @@ yes=Yes
 Invalid_Private_Hardware_folder=You can not add [sloeber]/arduinoPlugin to the private Hardware folders.
 Invalid_Private_Library_folder=You can not add [sloeber]/arduinoPlugin to the private Libraries folders.
 ui_put_in_version_control=Share in version control?
+target_maintain=Targets
+Add_Targets_To_force_serial_disconnect_when_run=Add targets that require the serial connection to be closed when build.

io.sloeber.ui/src/io/sloeber/ui/preferences/TargetSerialDisconnectPage.java

@@ -1,36 +1,28 @@
 
 package io.sloeber.ui.preferences;
 
-import org.eclipse.core.runtime.preferences.ConfigurationScope;
-import org.eclipse.jface.preference.FieldEditorPreferencePage;
-import org.eclipse.jface.preference.IPreferenceStore;
+import org.eclipse.jface.preference.PreferencePage;
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.layout.GridData;
+import org.eclipse.swt.layout.GridLayout;
 import org.eclipse.swt.widgets.Composite;
+import org.eclipse.swt.widgets.Control;
 import org.eclipse.swt.widgets.Label;
 import org.eclipse.swt.widgets.Text;
 import org.eclipse.ui.IWorkbench;
 import org.eclipse.ui.IWorkbenchPreferencePage;
-import org.eclipse.ui.preferences.ScopedPreferenceStore;
 
 import io.sloeber.core.api.Preferences;
 import io.sloeber.ui.Messages;
-import io.sloeber.ui.helpers.MyPreferences;
 
-public class TargetSerialDisconnectPage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage {
-	private static final String KEY_SERIAL_DISCONNECT_TARGETS = "Targets to disconnect Serial when build"; //$NON-NLS-1$
+public class TargetSerialDisconnectPage extends PreferencePage implements IWorkbenchPreferencePage {
 	private Text targetsText;
 
-	public TargetSerialDisconnectPage() {
-		super(org.eclipse.jface.preference.FieldEditorPreferencePage.GRID);
-		setDescription(Messages.json_maintain);
-		setPreferenceStore(new ScopedPreferenceStore(ConfigurationScope.INSTANCE, MyPreferences.NODE_ARDUINO));
-	}
 
 	@Override
 	public boolean performOk() {
 		Preferences.setDisconnectSerialTargets(targetsText.getText());
-		return super.performOk();
+		return true;
 	}
 
 	@Override
@@ -40,25 +32,24 @@ protected void performDefaults() {
 	}
 
 	@Override
-	protected void createFieldEditors() {
+	protected Control createContents(Composite parent) {
+		Composite control = new Composite(parent, SWT.NONE);
+		control.setLayout(new GridLayout());
 		String selectedTargets = Preferences.getDisconnectSerialTargets();
-		final Composite parent = getFieldEditorParent();
+
 		// Composite control = new Composite(parent, SWT.NONE);
-		Label title = new Label(parent, SWT.UP);
-		title.setFont(parent.getFont());
+		Label title = new Label(control, SWT.UP);
+		title.setFont(control.getFont());
 
-		title.setText(Messages.ui_url_for_index_file);
+		title.setText(Messages.Add_Targets_To_force_serial_disconnect_when_run);
 		title.setLayoutData(new GridData(GridData.VERTICAL_ALIGN_BEGINNING));
 
-		this.targetsText = new Text(parent, SWT.MULTI | SWT.V_SCROLL | SWT.BORDER | SWT.WRAP);
+		this.targetsText = new Text(control, SWT.MULTI | SWT.V_SCROLL | SWT.BORDER | SWT.WRAP);
 		GridData gd = new GridData(GridData.FILL_BOTH);
 		this.targetsText.setLayoutData(gd);
 		this.targetsText.setText(selectedTargets);
 
-		IPreferenceStore prefstore=getPreferenceStore();
-		prefstore.setValue(KEY_SERIAL_DISCONNECT_TARGETS, selectedTargets);
-//		prefstore.setDefault(KEY_SERIAL_DISCONNECT_TARGETS, true);
-
+		return control;
 	}
 
 	@Override

io.sloeber.ui/src/io/sloeber/ui/preferences/ThirdPartyHardwareSelectionPage.java

@@ -47,7 +47,7 @@ public boolean performOk() {
 	@Override
 	protected void performDefaults() {
 		super.performDefaults();
-		this.urlsText.setText(PackageManager.getDefaultURLs());	
+		this.urlsText.setText(PackageManager.getDefaultJsonURLs());
 	}
 
 	@Override