Add support for getting the UUID of a device #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/cust/src/device.rs
Outdated
| unsafe { | ||
| let mut cu_uuid = CUuuid { bytes: [0i8; 16] }; | ||
| cuDeviceGetUuid(&mut cu_uuid, self.device).to_result()?; | ||
| let uuid: [u8; 16] = ::std::mem::transmute(cu_uuid.bytes); |
There was a problem hiding this comment.
Using a transmute for just i8 -> u8 seems a bit odd, just using array.map() would be better.
There was a problem hiding this comment.
Fixed with the most recent push (I also fixed the commit message to match the usual style).
`Device::uuid()` was added to get the UUID of a device via the underlying `cuDevuceGetUuid()` call.
Instead of using the `to_ne_bytes()` function, cast directly as `u8`. Co-authored-by: Riccardo D'Ambrosio <[email protected]>
|
I can also squash and rebase the commit if you prefer that. |
|
I usually squash commits anyways, so this is fine :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device::uuid()was added to get the UUID of a device via the underlyingcuDevuceGetUuid()call.