Chore: Fix some warnings and add primer to README.md #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/cudnn/README.md
Outdated
|
|
||
| ### Device buffers | ||
|
|
||
| This crate is built around [`cust`](https://docs.rs/cust/latest/cust/memory/index.html) own memory routines and transfer functions. |
There was a problem hiding this comment.
This should prob just be "around cust" in general, maybe add "... which is our core wrapper for interfacing with the CUDA Driver API"
|
|
||
| cuDNN contexts can be created as shown in the following snippet: | ||
|
|
||
| ```rust |
There was a problem hiding this comment.
cudnn requires u to init first, no? at least cust does, maybe include initialization in this snippet?
There was a problem hiding this comment.
the snippet runs fine, but I will add the ctx init, moreover many cudnn structs can be initialised without a ctx, although the docs specify otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.