refactor(cust_raw): Parse macro function renames in cuda headers. #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorge-ortega
force-pushed
the
function-renames
branch
8 times, most recently
from
3b73676 to
39bd57e
Compare
|
TBH I don't know why Windows with v12 is passing when we never set LIBCLANG_PATH or installed Clang... |
Maybe it uses visual studio toolchains? |
|
A heads-up that I'm also working on a change to use prebuilt container images that contains NVidia toolchains so I might conflict with your github actions changes. |
Adds a custom bindgen callback that prevents function renames due to macro defines while still linking to the intend function after macro expansion. It does this by tracking macros when generating the bindings, so that it can change the name of the function back to what it was before the macro changed and link to the macro expanded function name. Doing so helps prevents breaking changes across CUDA versions when generating the bindings, and generates function bindings that match those used in Nvidia's CUDA documentation. misc.: optix-sys rebuilds if related optix environment variables change. misc.: unpin cc and jobserver from add example.
jorge-ortega
force-pushed
the
function-renames
branch
from
39bd57e to
88e5c83
Compare
|
Leaving this open in case anyone has comments and will merge in the morning unless @LegNeato beats me to it. I'll have additional changes to add move coverage of the sdk to try match what cudarc offers. |
|
Linking #166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a custom bindgen callback that prevents function renames due to macro defines while still linking to the intend function after macro expansion. It does this by tracking macros when generating the bindings, so that it can change the name of the function back to what it was before the macro changed and link to the macro expanded function name. Doing so helps prevents breaking changes across CUDA versions when generating the bindings, and generates function bindings that match those used in Nvidia's CUDA documentation.
misc.: optix-sys rebuilds if related optix environment variables change.
misc.: unpin cc and jobserver from add example.