Skip to content

MAINT: Fix small typos #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 15, 2024
Merged

MAINT: Fix small typos #362

merged 13 commits into from
Jan 15, 2024

Conversation

Smit-create
Copy link
Member

@Smit-create Smit-create commented Aug 19, 2023

This PR

  • removes %matplotlib inline as no longer required
  • removes redundant white space
  • removes +++ markers introduced by jupytext conversion

cc @mmcky

@github-actions
Copy link

github-actions bot commented Aug 19, 2023

@Smit-create Smit-create requested a review from mmcky August 26, 2023 06:05
@mmcky
Copy link
Contributor

mmcky commented Oct 22, 2023

thanks @Smit-create this looks great. Would you mind to resolve the minor conflicts and then I will merge.

@mmcky
Copy link
Contributor

mmcky commented Dec 12, 2023

thanks @Smit-create this looks great. Would you mind to resolve the minor conflicts and then I will merge.

@ kp992 would you mind to look into this?

@kp992
Copy link
Contributor

kp992 commented Dec 12, 2023

Thanks @mmcky. I have rebased it and made the changes locally but seems like a permission issue to push it on this branch.

remote: Permission to QuantEcon/lecture-python.myst.git denied to kp992.
fatal: unable to access 'https://github.com/QuantEcon/lecture-python.myst.git/': The requested URL returned error: 403

@mmcky
Copy link
Contributor

mmcky commented Dec 12, 2023

thanks @kp992 you are now a member of the python-lectures team

@kp992
Copy link
Contributor

kp992 commented Dec 14, 2023

thanks @kp992 you are now a member of the python-lectures team

thanks @mmcky. It's still showing the same error.

@mmcky
Copy link
Contributor

mmcky commented Dec 14, 2023

thanks @kp992 you are now a member of the python-lectures team

thanks @mmcky. It's still showing the same error.

@kp992 I believe you will need to fix the merge conflicts before the ci will run again

@kp992
Copy link
Contributor

kp992 commented Dec 14, 2023

I have merged the main branch into this branch, but when I try to push, I get the above error.

@mmcky
Copy link
Contributor

mmcky commented Dec 14, 2023

Oh I see -- try now?

@kp992
Copy link
Contributor

kp992 commented Dec 14, 2023

Done @mmcky, thank you so much.

@mmcky
Copy link
Contributor

mmcky commented Dec 19, 2023

thanks @Smit-create I will do a final review and merge once #361 and #355 are finalised

@mmcky mmcky added the review label Dec 19, 2023
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this tidy up @Smit-create

@mmcky
Copy link
Contributor

mmcky commented Dec 23, 2023

@Smit-create I am just running a full run without the build cache to test execution given there are some imports removed.

@Smit-create
Copy link
Member Author

Seems like everything is looking good. Thanks @mmcky

@mmcky mmcky self-requested a review January 15, 2024 03:00
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Smit-create -- this is great.

Please remember to fill in the top comment box with a description of the changes. I have added this to this PR. Thank you.

@Smit-create
Copy link
Member Author

Thanks @mmcky

@mmcky mmcky merged commit dd9fd01 into main Jan 15, 2024
@mmcky mmcky deleted the review-1-smit branch January 15, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants