-
-
Notifications
You must be signed in to change notification settings - Fork 52
MAINT: Fix small typos #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thanks @Smit-create this looks great. Would you mind to resolve the minor conflicts and then I will merge. |
@ kp992 would you mind to look into this? |
Thanks @mmcky. I have rebased it and made the changes locally but seems like a permission issue to push it on this branch.
|
thanks @kp992 you are now a member of the |
I have merged the main branch into this branch, but when I try to push, I get the above error. |
Oh I see -- try now? |
Done @mmcky, thank you so much. |
thanks @Smit-create I will do a final review and merge once #361 and #355 are finalised |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this tidy up @Smit-create
@Smit-create I am just running a full run without the build cache to test execution given there are some imports removed. |
Seems like everything is looking good. Thanks @mmcky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Smit-create -- this is great.
Please remember to fill in the top comment box with a description of the changes. I have added this to this PR. Thank you.
Thanks @mmcky |
This PR
%matplotlib inline
as no longer required+++
markers introduced byjupytext
conversioncc @mmcky