Skip to content

Improve the computation of the reservation wage #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

TaichiSakaguchi
Copy link
Contributor

Use numpy.searchsorted (which uses binary search) instead of the linear search in the original content.

if v[i] > h:
w_bar = wage
break
i = np.searchsorted(v,h,side = 'right')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add spaces after commas, no space around =.

@jstac
Copy link
Contributor

jstac commented Jul 3, 2023

Thanks @TaichiSakaguchi ! Please see the small request above.

@TaichiSakaguchi
Copy link
Contributor Author

I fixed the code as you requested.

@jstac
Copy link
Contributor

jstac commented Jul 3, 2023

Thanks @TaichiSakaguchi

@jstac
Copy link
Contributor

jstac commented Jul 3, 2023

@mmcky , could you please look at this when you have time? No rush. The build error says "level":"error","message":"token not found","stack":"Error: token not found\n...

@mmcky
Copy link
Contributor

mmcky commented Aug 8, 2023

thanks @jstac sorry I missed this one.

The build is failing due to the fork origin. It's a frustrating limitation but it is due to the need to use GitHub credentials.

I don't see an easy fix for these runner issues but I am looking into it. If the code looks good to go -- I think we can merge and the cache build will verify everything executes nicely.

@jstac
Copy link
Contributor

jstac commented Aug 8, 2023

Roger that @mmcky , merging.

@jstac jstac merged commit 6a24b31 into QuantEcon:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants