Skip to content

Fix Userwarning #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix Userwarning #353

merged 1 commit into from
Jun 26, 2023

Conversation

HengchengZhang
Copy link
Member

Hi @jstac, this PR fixes #208.

@github-actions
Copy link

@jstac
Copy link
Contributor

jstac commented Jun 26, 2023

Nice work @HengchengZhang .

I feel like there will be other instances of this throughout the lectures. I'll merge this but would you mind to do a quick search of the other lecture series and see?

@jstac jstac merged commit a4d4aaa into main Jun 26, 2023
@jstac jstac deleted the i-208 branch June 26, 2023 07:22
@HengchengZhang
Copy link
Member Author

Hi @jstac, this warning is because the use of the - symbol in k- has dulplicate settings with linestyle or ls.

I did a quick search in all quantecon codes in public repos and find this could originated from the same code here: https://github.com/QuantEcon/ShenzhenWinterCamp/blob/5eaea4e1e4bf9e23c6c968d07545c740131a4b14/John/scalar_dynamics.ipynb#L71

The good news is that our lectures are fine once #249 is merged and there is no warning message related to this issue anymore.

On the other hand we have this issue in three notebook repos which I don't have the access to modify.

The modification should be

ax.plot((x, x), (0, x), 'k-', ls='dotted')

to

ax.plot((x, x), (0, x), 'k', ls='dotted')

@jstac
Copy link
Contributor

jstac commented Jun 29, 2023

Good work @HengchengZhang . Let's leave it as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot warnings in 1D dynamics lecture
2 participants