Skip to content

add Macro syntax for argmax and argmin #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2021
Merged

add Macro syntax for argmax and argmin #35

merged 3 commits into from
Mar 4, 2021

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Jan 7, 2021

This PR adds TeX macros for argmin and argmax which should fix #31

@github-actions github-actions bot temporarily deployed to commit January 8, 2021 00:08 Inactive
@mmcky mmcky requested a review from shlff January 8, 2021 00:45
@mmcky
Copy link
Contributor Author

mmcky commented Jan 8, 2021

@shlff we should also fix other cases

Would you have time to go through:

https://github.com/QuantEcon/lecture-python/blob/b37408c7b5aeb3875767949c6449113bcd4b1702/conf.py#L263

and let me know which ones we need?

I would suggest using grep to see if they are needed. For example

grep -r "RR" source/rst/*

will give you a list of all cases of RR

@shlff
Copy link
Member

shlff commented Jan 11, 2021

@shlff we should also fix other cases

Would you have time to go through:

https://github.com/QuantEcon/lecture-python/blob/b37408c7b5aeb3875767949c6449113bcd4b1702/conf.py#L263

and let me know which ones we need?

I would suggest using grep to see if they are needed. For example

grep -r "RR" source/rst/*

will give you a list of all cases of RR

Thanks @mmcky . I checked all cases from \RR to \argmin in the list through all lecture-python lectures via grep and find

  • \argmax is the only case we need to fix

Do you want me to check more cases? If not, then I think this PR can be merged safely.

@AakashGfude
Copy link
Member

LaTeX equivalent of this is done in #35

@github-actions github-actions bot temporarily deployed to commit March 4, 2021 23:13 Inactive
@mmcky mmcky merged commit e25e32c into main Mar 4, 2021
@mmcky mmcky deleted the update-tex-macros branch March 4, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lecture_comparison][rational_expectations] \argmax Issue
3 participants