Revert JAX Content in Newton's Method #340

HumphreyYang · 2023-05-09T12:46:10Z

This resolves #339.

HumphreyYang · 2023-05-09T23:19:07Z

Hi @mmcky,

Could you please send me the error log, as the error did not appear in my local build?

Many thanks in advance.

mmcky · 2023-05-09T23:20:43Z

@HumphreyYang if you:

click on the failed build link
click on Summary in the left hand column

you can download the execution error reports as a build artifact.

mmcky · 2023-05-09T23:21:34Z

In this case the error is

ValueError: shapes (3,3) and (3000,) not aligned: 3 (dim 1) != 3000 (dim 0)

from this cell

nbclient.exceptions.CellExecutionError: An error occurred while executing the following cell:
------------------
e(p, A, b, c)
------------------

HumphreyYang · 2023-05-10T00:06:56Z

Many thanks @mmcky,

This is strange. I just couldn't replicate the error locally and the error is not related to the environment. Would you mind resetting the cache so that I can have another go?

mmcky · 2023-05-10T02:57:07Z

@HumphreyYang is this expected behaviour for iteration == 1

HumphreyYang · 2023-05-10T03:01:09Z

@HumphreyYang is this expected behaviour for iteration == 1

Many thanks @mmcky,

This is expected as it shows sometimes newton's method can fail.

HumphreyYang · 2023-05-10T06:05:05Z

Hi @mmcky,

The errors now are:

/__w/lecture-python.myst/lecture-python.myst/lectures/mccall_model.md:687: WARNING: Could not lex literal_block as "ipythontb". Highlighting skipped.
/__w/lecture-python.myst/lecture-python.myst/lectures/career.md:470: WARNING: Could not lex literal_block as "ipythontb". Highlighting skipped.

Any ideas on how should I resolve them?

Many thanks in advance.

mmcky · 2023-05-10T07:27:19Z

Hi @mmcky,

The errors now are:

/__w/lecture-python.myst/lecture-python.myst/lectures/mccall_model.md:687: WARNING: Could not lex literal_block as "ipythontb". Highlighting skipped.
/__w/lecture-python.myst/lecture-python.myst/lectures/career.md:470: WARNING: Could not lex literal_block as "ipythontb". Highlighting skipped.

Any ideas on how should I resolve them?

Many thanks in advance.

Those errors mean there is some traceback in some output. Can you replicate this locally on a clean build?

mmcky · 2023-05-10T07:29:37Z

I am getting them locally on quantecon-gpu-server1

/home/mmcky/work/lecture-python.myst/lectures/career.md:470: WARNING: Could not lex literal_block as "ipythontb". Highlighting skipped.
/home/mmcky/work/lecture-python.myst/lectures/mccall_model.md:735: WARNING: Could not lex literal_block as "ipythontb". Highlighting skipped.

and it looks like no python jit is failing

There are 2 candidate implementations:
      - Of which 2 did not match due to:


TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Failed in nopython mode pipeline (step: nopython frontend)
No implementation of function Function(<function draw at 0x7f5cca47b400>) found for signature:
 
 >>> draw(array(float64, 1d, C))
 
There are 2 candidate implementations:
      - Of which 2 did not match due to:
      Overload in function 'ol_draw': File: quantecon/random/utilities.py: Line 213.
        With argument(s): '(array(float64, 1d, C))':
       Rejected as the implementation raised a specific error:
         TypingError: missing a required argument: 'size'
  raised from /home/mmcky/anaconda3/envs/quantecon/lib/python3.10/site-packages/numba/core/typing/templates.py:791

During: resolving callee type: Function(<function draw at 0x7f5cca47b400>)
During: typing of call at /tmp/ipykernel_130272/786420040.py (16)


File "../../../../../tmp/ipykernel_130272/786420040.py", line 16:
<source missing, REPL/exec in use?>

During: resolving callee type: type(CPUDispatcher(<function passage_time at 0x7f5cb5398d30>))
During: typing of call at /tmp/ipykernel_130272/786420040.py (25)

During: resolving callee type: type(CPUDispatcher(<function passage_time at 0x7f5cb5398d30>))
During: typing of call at /tmp/ipykernel_130272/786420040.py (25)


File "../../../../../tmp/ipykernel_130272/786420040.py", line 25:
<source missing, REPL/exec in use?>

mmcky · 2023-05-10T07:31:54Z

@HumphreyYang I will open a separate to test build the current main to rule that out.

… into revert-newton

github-actions · 2023-05-16T01:04:49Z

🚀 Deployed on https://647ed8c253c1bc6d10b28f25--nostalgic-wright-5fa355.netlify.app

mmcky · 2023-05-16T06:12:53Z

@mmcky to review pdf

HumphreyYang · 2023-05-16T06:33:46Z

Hi @jstac,

This is now ready for your review. As this PR resolves some of the bugs that appeared in the CI, once this is merged (after @mmcky resolves the PDF build issue), I will do a merge in each PR to get the CI building again.

Many thanks in advance.

mmcky · 2023-05-16T23:11:26Z

@HumphreyYang the issue with the pdf should be fixed by #343

HumphreyYang · 2023-05-17T01:07:18Z

@HumphreyYang the issue with the pdf should be fixed by #343

Many thanks @mmcky. I saw the PDF has been built successfully. Please merge the PR when you are ready and I will merge main to this and hand it over to @jstac!

mmcky · 2023-05-17T02:03:47Z

@HumphreyYang the issue with the pdf should be fixed by #343

Many thanks @mmcky. I saw the PDF has been built successfully. Please merge the PR when you are ready and I will merge main to this and hand it over to @jstac!

@HumphreyYang I merged main in so should be fixed after this build.

HumphreyYang · 2023-05-23T07:32:39Z

Hi @jstac,

This PR is ready for your review. Many thanks in advance.

HumphreyYang · 2023-05-23T14:25:45Z

As the bug in quantecon.py has been fixed. I will revert the temporary fix in this PR once the package is updated.

Please feel free to go ahead and merge this before we have a new publish in quantecon.py. I will track this issue once this PR is merged. Please also feel free to leave this open until the new publish.

jstac · 2023-05-27T07:01:57Z

Many thanks @HumphreyYang .

@mmcky , would you mind to keep handling this one?

mmcky · 2023-05-29T00:37:55Z

needs a new release of quantecon==0.7.1 RELEASE: Setup v0.7.1 QuantEcon.py#709

mmcky · 2023-05-30T10:07:25Z

@HumphreyYang I have triggered another build now that a new version of quantecon has been released

HumphreyYang · 2023-05-31T03:23:38Z

Hi @mmcky,

This is ready to be merged. Please kindly review these changes and let me know if further changes are needed.

Many thanks.

mmcky · 2023-06-06T06:44:09Z

thanks @HumphreyYang

HumphreyYang · 2023-06-06T06:46:27Z

Hi @mmcky,

Should we wait for the build to come alive before we publish? I will have a quick look to see what changes were brought into the lecture.

Many thanks.

mmcky · 2023-06-06T06:57:26Z

@HumphreyYang I will wait until we get green ticks on the fresh cache build before triggering a publish. That currently takes 1.5 hours so I will release the update later this evening.

mmcky · 2023-06-06T06:58:22Z

@HumphreyYang please check the final build on this PR and let me know if all looks as expected. I merged to get the cache building

HumphreyYang · 2023-06-06T07:07:34Z

Hi @mmcky, looks like the merge got some JAX into the lecture. I will restore this branch and merge it again. Apologies for the inconvenience.

HumphreyYang added 5 commits May 9, 2023 22:45

update newton_method

1099889

add a comment on import

2b08451

update seealso at the beginning of the lecture

d35e20e

add pip install

ac5063d

update to accept error

2a5705f

TMP: remove cache for a full build

1e813e7

mmcky mentioned this pull request May 10, 2023

TEST: remove cache for full build #342

Closed

HumphreyYang added 9 commits May 15, 2023 13:37

Merge branch 'main' of https://github.com/QuantEcon/lecture-python.myst…

45b13d1

… into revert-newton

fix bugs in career and mccall model

c6fc30c

revert changes in CI

d6ddfcf

remove the time magic

a829aeb

use try-catch instead relying on myst

1aa6b99

add raises-exception tag

ef994e0

catch all errors

1cdb306

add a clear example for the function

e97d187

check output for the solution

734410c

HumphreyYang added 3 commits May 16, 2023 11:44

add max iter

dc7d1e5

update max_iter

1e988ac

check the output of the line before

801ea6f

HumphreyYang added 2 commits May 16, 2023 15:25

fix convergence issue

5e6dfb4

finalize the code

3d0456d

mmcky mentioned this pull request May 16, 2023

FIX: syntax for PDF builds #343

Merged

Merge branch 'main' into revert-newton

b801b83

mmcky requested a review from jstac May 17, 2023 02:42

HumphreyYang added 2 commits May 23, 2023 16:43

remove try-catch to raise errors

5a14609

update the runtime comparison

a0b588a

HumphreyYang added 2 commits May 30, 2023 22:01

revert temprary bug fixes

8a475c6

move exercises in mccall model

a56dd0d

Merge branch 'main' into revert-newton

ed4f1f5

mmcky merged commit 95edcd8 into main Jun 6, 2023

mmcky deleted the revert-newton branch June 6, 2023 06:44

HumphreyYang restored the revert-newton branch June 6, 2023 07:07

Uh oh!

Revert JAX Content in Newton's Method #340

Revert JAX Content in Newton's Method #340

Uh oh!

Conversation

HumphreyYang commented May 9, 2023

Uh oh!

HumphreyYang commented May 9, 2023

Uh oh!

mmcky commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmcky commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HumphreyYang commented May 10, 2023

Uh oh!

mmcky commented May 10, 2023

Uh oh!

HumphreyYang commented May 10, 2023

Uh oh!

HumphreyYang commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmcky commented May 10, 2023

Uh oh!

mmcky commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmcky commented May 10, 2023

Uh oh!

github-actions bot commented May 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmcky commented May 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HumphreyYang commented May 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmcky commented May 16, 2023

Uh oh!

HumphreyYang commented May 17, 2023

Uh oh!

mmcky commented May 17, 2023

Uh oh!

HumphreyYang commented May 23, 2023

Uh oh!

HumphreyYang commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jstac commented May 27, 2023

Uh oh!

mmcky commented May 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmcky commented May 30, 2023

Uh oh!

HumphreyYang commented May 31, 2023

Uh oh!

mmcky commented Jun 6, 2023

Uh oh!

HumphreyYang commented Jun 6, 2023

Uh oh!

mmcky commented Jun 6, 2023

Uh oh!

mmcky commented Jun 6, 2023

Uh oh!

HumphreyYang commented Jun 6, 2023

Uh oh!

Uh oh!

mmcky commented May 9, 2023 •

edited

Loading

mmcky commented May 9, 2023 •

edited

Loading

HumphreyYang commented May 10, 2023 •

edited

Loading

mmcky commented May 10, 2023 •

edited

Loading

github-actions bot commented May 16, 2023 •

edited

Loading

mmcky commented May 16, 2023 •

edited

Loading

HumphreyYang commented May 16, 2023 •

edited

Loading

HumphreyYang commented May 23, 2023 •

edited

Loading

mmcky commented May 29, 2023 •

edited

Loading