Skip to content

Update lecture-python sources with latest updates #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Jan 6, 2021

This PR updates the source files from lecture-python (dbd838d) using sphinx-tomyst (b06cacb)

@shlff this PR should contain all of your recent PR's that have been merged in addition to changes from Tom and John (over the past two weeks).

If you could take a look to see it looks as expected (from your commits) that would be great.

@github-actions github-actions bot temporarily deployed to commit January 6, 2021 06:08 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Jan 6, 2021

Note: this will be missing the 6 lectures that require code execution until #16 is merged.

@mmcky
Copy link
Contributor Author

mmcky commented Jan 6, 2021

@shlff I am going to merge this now but when you get the chance I'd appreciate you taking a quick look at the diff and let me know if it looks about right -- with regards to your recent changes. I have converted this from lecture-python using sphinx-tomyst

@mmcky mmcky merged commit 7e78afa into main Jan 6, 2021
@mmcky mmcky deleted the update-sources branch January 6, 2021 08:22
@shlff
Copy link
Member

shlff commented Jan 6, 2021

Great thanks for your nice work, @mmcky . Sorry for my late reply. sphinx-tomyst is really cool!

I checked all this PR's changes, most of which look right except the one for lecture short_path.md:

Screen Shot 2021-01-06 at 10 59 23 pm

Since it is in myst, so the context after the change in that lecture (the left in the above screenshot) should be:

  • (Graphs such as the one above are called **weighted [directed graphs](https://en.wikipedia.org/wiki/Directed_graph)**.)

Do you want me to submit a PR to correct this?

I will check these more carefully again, compared with my merged PRs in lecture-python.

Btw, should I submit my next PRs for improving lectures in this repo?

@mmcky
Copy link
Contributor Author

mmcky commented Jan 7, 2021

@shlff looking at the source rst this seems correct

(Graphs such as the one above are called **weighted `directed graphs <https://en.wikipedia.org/wiki/Directed_graph>`_**.)

@mmcky
Copy link
Contributor Author

mmcky commented Jan 7, 2021

@shlff oh I see the issue -- thanks. It should be updated. Would you mind setting up a new PR in this repo with the update and tag it as manual-change

Can you also document this issue on sphinx-tomyst issue register as a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants