Skip to content

MAINT: update them to quantecon-book-theme=0.2.1 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 17, 2021
Merged

MAINT: update them to quantecon-book-theme=0.2.1 #137

merged 5 commits into from
May 17, 2021

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented May 6, 2021

This updates to use the latest quantecon-book-theme

@mmcky
Copy link
Contributor Author

mmcky commented May 6, 2021

@shlff this is a build of: https://python.quantecon.org/intro.html using the latest quantecon-book-theme.

@AakashGfude has done some nice work on refactoring our theme and adding some new features.

It would be great if you could spend a bit of time comparing the current live site with this PR build (as a double check).

Hopefully you won't find many differences :-)

@mmcky mmcky requested a review from shlff May 6, 2021 03:13
@github-actions github-actions bot temporarily deployed to commit May 6, 2021 03:19 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented May 6, 2021

@shlff also just to clarify - there is no need to recheck the whole site. Just wanted another set of eyes to:

  1. do some random spot checks
  2. look for some of the issues that have cropped up before

@shlff
Copy link
Member

shlff commented May 11, 2021

Thanks @mmcky . I randomly selected some lectures and here are all the differences I found (left: live website, right: preview of this PR):

  1. bold font for subsubsection titles in the preview
    Screen Shot 2021-05-12 at 8 11 00 am

  2. different arrow style in latex math expressions
    Screen Shot 2021-05-12 at 8 12 21 am

  3. different fontsize for latex math expressions
    Screen Shot 2021-05-12 at 8 16 17 am

  4. extra space above and below code cells in the preview
    Screen Shot 2021-05-12 at 8 18 24 am

  5. problematic fraction forms of math expressions created by python code (the score between fractions is missing)
    Screen Shot 2021-05-12 at 8 19 43 am

  6. centralized between-text math expressions (I think it should be a desired feature.)
    Screen Shot 2021-05-12 at 8 22 25 am

  7. red-colour quoted in-text code (I think it should be a desired feature.)
    Screen Shot 2021-05-12 at 8 27 02 am

  8. the inserted figures aligned to the left (rather than to the center) in the preview
    Screen Shot 2021-05-12 at 8 30 08 am

  9. failure to compile \boldsymbol in the preview
    Screen Shot 2021-05-12 at 8 35 29 am

Screen Shot 2021-05-12 at 8 36 06 am

  1. the color of quoted code in the title is blue rather than red like other in-text quoted code in the preview
    Screen Shot 2021-05-12 at 8 37 38 am

  2. missing latex math expressions in the preview
    Screen Shot 2021-05-12 at 8 44 55 am

  3. different styles for between-text quoted code (I think it should be a desired feature.)
    Screen Shot 2021-05-12 at 8 50 53 am

  4. output is broken into more parts in the preview
    Screen Shot 2021-05-12 at 8 57 55 am

  5. different styles for Note (I think it should be a desired feature.)
    Screen Shot 2021-05-12 at 9 03 15 am

@mmcky
Copy link
Contributor Author

mmcky commented May 12, 2021

thanks @shlff there are some great pickups here. Thank you!

@mmcky
Copy link
Contributor Author

mmcky commented May 12, 2021

@mmcky
Copy link
Contributor Author

mmcky commented May 12, 2021

@shlff for issue 3 in your list -- I think the actual math is not quite put together as intended.

$$
\begin{aligned} p_0  & = x_0 + x_1/R + x_2/(R^2) + \ddots \\
                 & = x_0 (1 + G R^{-1} + G^2 R^{-2} + \cdots ) \\
                 & = x_0 \frac{1}{1 - G R^{-1}} \end{aligned}
$$

do you think \ddots should be \cdots?

@shlff
Copy link
Member

shlff commented May 12, 2021

@shlff for issue 3 in your list -- I think the actual math is not quite put together as intended.

$$
\begin{aligned} p_0  & = x_0 + x_1/R + x_2/(R^2) + \ddots \\
                 & = x_0 (1 + G R^{-1} + G^2 R^{-2} + \cdots ) \\
                 & = x_0 \frac{1}{1 - G R^{-1}} \end{aligned}
$$

do you think \ddots should be \cdots?

Thanks @mmcky . I think \ddots is fine, but just find that the font size of the whole math expression in the preview is larger than that from the live website, which might not be an issue.

@github-actions github-actions bot temporarily deployed to commit May 13, 2021 22:29 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented May 13, 2021

@mmcky
Copy link
Contributor Author

mmcky commented May 13, 2021

thanks @shlff I think we have addressed the content issues that you identified in the lastest update to use svg rendering. If you could take a quick look today (~10min) and let me know it is working on your end that would be great.

@github-actions github-actions bot temporarily deployed to commit May 13, 2021 22:46 Inactive
@shlff
Copy link
Member

shlff commented May 14, 2021

Thanks @mmcky . I just checked them and can confirm that issue 5 mentioned above has been solved.

@github-actions github-actions bot temporarily deployed to commit May 14, 2021 06:18 Inactive
@github-actions github-actions bot temporarily deployed to commit May 14, 2021 06:36 Inactive
@github-actions github-actions bot temporarily deployed to commit May 14, 2021 07:48 Inactive
@mmcky mmcky changed the title MAINT: update them to quantecon-book-theme=0.2.0 MAINT: update them to quantecon-book-theme=0.2.1 May 17, 2021
@mmcky
Copy link
Contributor Author

mmcky commented May 17, 2021

@AakashGfude @shlff I think we are ready to merge this and deploy python.quantecon.org running quantecon-book-theme=0.2.1

@mmcky mmcky merged commit 79a7b95 into main May 17, 2021
@mmcky mmcky deleted the theme=0.2.0 branch May 17, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants