Skip to content

Misc edits to prob lecture #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2024
Merged

Misc edits to prob lecture #539

merged 3 commits into from
Aug 1, 2024

Conversation

jstac
Copy link
Contributor

@jstac jstac commented Jul 31, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented Jul 31, 2024 •
edited
Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 39bdc06
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66aad8c39580d00008080b2b
😎 Deploy Preview https://deploy-preview-539--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jstac
Copy link
Contributor Author

jstac commented Jul 31, 2024

@mmcky , would you mind to tweak this, do a quick proofread of my changes and then make it live?

mmcky
mmcky approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jstac just one question that may be helpful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

🚀 Deployed on https://66aadaa85329ce3eebf43afc--taupe-gaufre-c4e660.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 00:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 00:06 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 00:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 00:45 Inactive
@jstac
Copy link
Contributor Author

jstac commented Aug 1, 2024

Can x = np.asarray(df['income']) be simplified to x = np.array(df['income']) ?

@jstac
Copy link
Contributor Author

jstac commented Aug 1, 2024

The FutureWarnings look a bit ugly -- should we suppress them?

@mmcky mmcky merged commit 21a6894 into main Aug 1, 2024
7 checks passed
@mmcky mmcky deleted the edit_prob branch August 1, 2024 02:39
@mmcky
Copy link
Contributor

mmcky commented Aug 1, 2024

The FutureWarnings look a bit ugly -- should we suppress them?

Ah just saw this -- will review.

@mmcky mmcky mentioned this pull request Aug 1, 2024
Merged
@mmcky mmcky restored the edit_prob branch August 1, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcky mmcky mmcky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstac @mmcky