-
-
Notifications
You must be signed in to change notification settings - Fork 25
[heavy_tails] Incorporate Feedback from #418 #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I revise the references, and all of them are contextual; there are no references to graphs. Additionally, I make some changes to the titles of the graphs. |
Thanks @SylviaZhaooo happy for you to commit changes to this branch. I think I may have confused you. You will see from the netlify deployment figures are now titled and numbered. https://662b428b92dc90768bd78f2d--taupe-gaufre-c4e660.netlify.app/heavy_tails#hist-obs This is due to the You can reference these figures in the text using the |
Oh, I see. Thanks for illustrating the function of the |
Thanks @HumphreyYang for the suggestion of the Is this what you were thinking of: https://662ef57d1ac31245c722536a--taupe-gaufre-c4e660.netlify.app/heavy_tails#q-q-plots |
lectures/heavy_tails.md
Outdated
@@ -1096,6 +1096,8 @@ $(0, \infty)$. | |||
|
|||
The Pareto distribution is also heavy-tailed. | |||
|
|||
Less formally, a **heavy-tailed** distribution is one that is not exponentially bounded (i.e. the tails are heavier than the exponential distribution). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jstac not sure we should keep this but this is one "explanation" based on the wiki page. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's useful but maybe remove bold face because this is not the formal definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @jstac didn't scroll all the way to see this. 👍
I will adjust now.
Many thanks @mmcky. Yes, that's what's on my mind. Personally, I think the Q-Q plot needs to be a square plot to show the tails better : ) |
--- | ||
mystnb: | ||
figure: | ||
caption: Histogram of observations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jstac should the be draws
instead of observations
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think either is fine.
lectures/heavy_tails.md
Outdated
--- | ||
mystnb: | ||
figure: | ||
caption: Histogram (Normal vs Bitcoin returns) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jstac I have used capitals for Normal
and Bitcoin
. Is that correct style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually follow Wikipedia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jstac I see. I have changed Normal to normal in text and kept Cauchy and Pereto (as names) capitalised as per wikipedia.
These look a lot nicer in ![]() |
@jstac this is ready for review -- with some comments above. |
Thanks @mmcky -- please see "I think it's useful but maybe remove bold face because this is not the formal definition." |
Many thanks @mmcky and @SylviaZhaooo . Merging. |
This PR implements the following changes as discussed in #418
yf.download
and suppress messy output{numref}`<label>`
and review the titles of each figure?)
Q-Q
plot