[markov_II] FIX: fix state transition figure in lecture #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
|
Thanks @mmcky @HumphreyYang , could you please do a first round review? |
| @@ -295,6 +295,7 @@ The transition graph shows that this model is irreducible. | |||
| ```{image} /_static/lecture_specific/markov_chains_II/example4.png | |||
| :name: mc_example4 | |||
| :align: center | |||
| :scale: 80% | |||
There was a problem hiding this comment.
Many thanks @mmcky,
The code looks great to me.
On my side, the image looks slightly too wide:
Should we adjust the aspect ratio to make it narrower?
There was a problem hiding this comment.
I think #394 (comment) should fix the error. It would also keep it consistent with other figures in the lecture.
|
Closing this PR and will open another based on comment in #394 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #394
example4.pngfileThere is some discussion around making these figures using
mermaidas the source is then included in the lecture and moves us closer to self contained documents. However in the short/medium term we will need to assessLaTeXcompatibility.