Skip to content

Adjust Graph Arrangement in cagan_ree #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Adjust Graph Arrangement in cagan_ree #229

merged 2 commits into from
Jun 6, 2023

Conversation

HumphreyYang
Copy link
Collaborator

This resolves #228.

@netlify
Copy link

netlify bot commented Jun 5, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 612bd61
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/647e8f771450e30008f177d2
😎 Deploy Preview https://deploy-preview-229--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

@HumphreyYang
Copy link
Collaborator Author

Hi @jstac,

This PR is ready for your review. In addition to changing the layout of the plots in cagan_ree, I have also updated the global plot scale from 80% to 90% so that plots are more Legible (i.e., the highlight plots in the long_run_growth lecture).

Please kindly let me know if anything needs to be further improved. Many thanks in advance.

@jstac
Copy link
Contributor

jstac commented Jun 6, 2023

Thanks @HumphreyYang , nice work. But please revert global plot size to 80% and let's think about that separately.

@HumphreyYang
Copy link
Collaborator Author

HumphreyYang commented Jun 6, 2023

Many thanks @jstac,

The change has been reverted. By looking at the build, I think 90% looks better on my side, but we can discuss this further in a separate issue.

@jstac
Copy link
Contributor

jstac commented Jun 6, 2023

Thanks @HumphreyYang , let's discuss it separately.

Nice work on this lecture.

@jstac jstac merged commit f76901b into main Jun 6, 2023
@jstac jstac deleted the caganree-graph branch June 6, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change fig dimensions in cagan_ree
2 participants