Skip to content

Fix supply demand #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 28, 2023
Merged

Fix supply demand #176

merged 10 commits into from
Apr 28, 2023

Conversation

HengchengZhang
Copy link
Member

@HengchengZhang HengchengZhang commented Apr 26, 2023

Hi @jstac, this PR

  • Check grammar
  • Reformat code, eg add white spaces and CamelCase for classes
  • Capitalise headings

for #138 #139 #140

@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit b0a1ae9
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/64488863ca7fab00088bf32b
😎 Deploy Preview https://deploy-preview-176--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 26, 2023

@jstac
Copy link
Contributor

jstac commented Apr 26, 2023

Thanks @HengchengZhang , much appreciated.

I think some of this will clash with #143 , which I opened a couple of days ago.

Shall we merge #143 and then adjust this one?

@HengchengZhang
Copy link
Member Author

Thanks John, I'm cool with this.

We can get #143 merged first and then look back at this. I can solve the possible conflicts then.

@jstac
Copy link
Contributor

jstac commented Apr 26, 2023

Sorry, I meant #169 😬

I'll assume you are also okay with me merging that. I'll go ahead and do it now.

@mmcky mmcky merged commit aeb306c into main Apr 28, 2023
@mmcky mmcky deleted the supply_demand branch April 28, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants