Skip to content

[cagan_adaptive] Editorial Suggestions #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
15 tasks done
HumphreyYang opened this issue Mar 10, 2024 · 4 comments
Closed
15 tasks done

[cagan_adaptive] Editorial Suggestions #392

HumphreyYang opened this issue Mar 10, 2024 · 4 comments
Assignees
@longye-tian
Labels
reading-group-2024

Comments

@HumphreyYang
Copy link
Collaborator

HumphreyYang commented Mar 10, 2024 •
edited by longye-tian
Loading

Code

  • change the name create_cagan_model to create_cagan_adaptive_model
  • Set the default values in create_cagan_adaptive_model instead of global parameters.
  • Add code comment to the code.
  • change inv to solve.
  • remove extra print when checking the stability of dynamics. in the section of 14.6. Technical condition for stability and add a new section that focuses on experiments.

Content

  • 'monetarist theory of price levels ' -> 'a monetarist theory of price levels '.
  • There is an extra quotation mark at the end of the second sentence.
  • $exp(\frac{m^d_t}{p_t})$ -> $exp(m^d_t - p_t)$.
  • Explain the variables such as sensitivity and expected rate of inflation and give admissible range of the parameters.
  • endogenous input -> exogenous input
  • give names to matrices and equations so that they can be referred in the code comment.
  • Add comments in this function and give titles to subplots.
  • Change subtitle "Forcast error" -> "Forcast error and model computation"
  • Change the time notations for equations in the section "Experiment 1"
  • Add an exercise that asks readers to explain the phenomenon in experiment 1.
longye-tian added a commit that referenced this issue Mar 13, 2024
@longye-tian
Update cagan_adaptive.md
3c7f340 
Solve some of the issues in #392, specifically:
- change the name `create_cagan_model` to `create_cagan_adaptive_model`

- Change 'monetarist theory of price level' to 'A monetarist theory of price level'

- Remove the extra quotation mark in the second sentences

- Change 'endogenous input' to 'exogenous input'
@longye-tian longye-tian mentioned this issue Mar 13, 2024
Merged
@longye-tian
Copy link
Collaborator

longye-tian commented Mar 13, 2024 •
edited
Loading

@jstac Hi John, I want to create a pull request for the following suggestions in the lecture [cagan_adaptive]. Do you think these are non-controversial?

  • Set the default values in create_cagan_adaptive_model instead of global parameters.
  • change inv to solve.
  • remove extra print when checking the stability of dynamics. in the section of 14.6. Technical condition for stability and add a new section that focuses on experiments.
  • give names to matrices and equations so that they can be referred in the code comment.
  • Add comments in this function and give titles to subplots.
  • Change subtitle "Forcast error" -> "Forcast error and model computation"
  • Change the time notations for equations in the section "Experiment 1"

@jstac
Copy link
Contributor

jstac commented Mar 13, 2024

@longye-tian No, those are not controversial and will definitely improve the lecture. Please go ahead!

@longye-tian
Copy link
Collaborator

Thank you for your feedback!

I'll proceed with implementing them to enhance the lecture.

longye-tian added a commit that referenced this issue Mar 14, 2024
@longye-tian
[cagan_adaptive] Update the code suggestions
d6a9a03 
Update coding suggestion in issue #392, more specifically, this pull request is related to
- Set the default values in  `create_cagan_adaptive_model` instead of global parameters. (Some parameters are still global and move to the Experiment 1 section as they are not part of the `create_cagan_adaptive_model`)
- change `inv` to `solve` (I also modified the name of `solve` function to `solve_cagan_adaptive` to avoid confusion with the `solve` function in `np`)
- remove extra print when checking the stability of dynamics.
- in the section of 14.6. Technical condition for stability and add a new section that focuses on experiments.
- give names to matrices and equations so that they can be referred in the code comment (I add comment in code to suggest matrix D is the coefficient matrix of equation (14.8))
- Add comments in this function and give titles to subplots.
- Change subtitle "Forcast error" ->  "Forcast error and model computation"
- Change the time notations for equations in the section "Experiment 1"
@longye-tian longye-tian mentioned this issue Mar 14, 2024
Merged
longye-tian added a commit that referenced this issue Jul 19, 2024
@longye-tian
[cagan_adaptive] update suggestions
f6595ec 
Dear John,

This pull request is to update the last comment from #392.

In particular, this pull request add the explanation for the parameter $\alpha$ and $\lambda$.

Best,
Longye
@longye-tian longye-tian mentioned this issue Jul 19, 2024
Merged
jstac pushed a commit that referenced this issue Jul 19, 2024
@longye-tian
[cagan_adaptive] update suggestions (#516)
edfca6e 
* [cagan_adaptive] update suggestions

Dear John,

This pull request is to update the last comment from #392.

In particular, this pull request add the explanation for the parameter $\alpha$ and $\lambda$.

Best,
Longye

* Update cagan_adaptive.md
@longye-tian
Copy link
Collaborator

This issue is now closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@longye-tian longye-tian

Labels
reading-group-2024
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jstac @HumphreyYang @longye-tian