Skip to content

[inflation_history] Review comments #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
7 tasks done
mmcky opened this issue Feb 15, 2024 · 0 comments
Closed
7 tasks done

[inflation_history] Review comments #371

mmcky opened this issue Feb 15, 2024 · 0 comments
Assignees
@mmcky

Comments

@mmcky
Copy link
Contributor

mmcky commented Feb 15, 2024 •
edited
Loading

  • It would be nice if the figures were numbered.

  • Sometimes the right and top axes are shown (a box around the plot) and sometimes not.
    It would be good to unify at a simple default.

  • The line in the Austria inflation plot needs the label "three month moving average".

  • And why grey instead of letting Matplotlib choose the colors?

(Similar comments apply to the other countries.)

  • In the text "Data underlying our..." there should be a statement of the functions that are hidden and what they do.

  • In "This pattern is an instance of a force featured in the purchasing power parity theory of exchange rates (see https://en.wikipedia.org/wiki/Purchasing_power_parity)." the phrase "purchasing power parity" should be a hyperlink and the text in brackets deleted.

  • run spell check
@mmcky mmcky self-assigned this Feb 15, 2024
mmcky added a commit that referenced this issue Feb 15, 2024
@mmcky
update to incorporate feedback in #371
2d2537c
@mmcky mmcky mentioned this issue Feb 15, 2024
Merged
11 tasks
mmcky added a commit that referenced this issue Feb 16, 2024
@mmcky
ENH: move inflation_history to economic data (#370)
147d10f 
* move inflation_history to economic data

* @mmcky edits and review

* update to incorporate feedback in #371

* MAINT: update action versions for ci

* minor edits and set standard figsize

* use figsize from qe manual

* adjust figsize,font globally and remove embedded figure text

* clean up old scale

* reformat doc references to use titles

* @mmcky final edit

* update reference to figure

* fix fraction

* FIX: add back in xlrd

* incorporate round 2 feedback from @jstac

* fix missing word

* fix github link

* update lw=2 for more vivid lines in figures

* adjust within figure text to be in QuantEcon style

* simplfiy matplotlib config + migrate fig text to labels
@mmcky mmcky closed this as completed Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmcky mmcky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmcky