Skip to content

take() implementation, rebase #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2023
Merged

take() implementation, rebase #98

merged 3 commits into from
Mar 31, 2023

Conversation

ev-br
Copy link
Collaborator

@ev-br ev-br commented Mar 31, 2023

Rebase gh-96 on main now that all the normalizations are in and the split between the wrapper and implementations is (mostly) gone.

@ev-br ev-br requested a review from honno March 31, 2023 15:03
honno
honno approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@honno honno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (nice work on the out stuff in #93)

@ev-br ev-br merged commit 7851aed into main Mar 31, 2023
@ev-br ev-br deleted the take_rebase branch March 31, 2023 15:38
@ev-br ev-br mentioned this pull request Mar 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honno honno honno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ev-br @honno