Add filter windows, tensordot #95
Conversation
There was a problem hiding this comment.
The docs say that M is an int, and so do the examples in the docs. As such, it is the tests that are wrong. We can still make the test pass implementing this undocumented behaviour, or simply remove them. At any rate, M should be of type int or at most Union[int, ArrayLike]. What I'm trying to avoid here is that unconditional wrapping of the int and an unconditional call to item() (which is data dependent and would cause issues when tracing through it).
ev-br
force-pushed
the
merge_detail
branch
2 times, most recently
from
e75772d to
f9f9ba4
Compare
|
The issue here is that an int is an array_like. And this is not the only undocumented behavior seen in the numpy test suite. So far I tried to minimize tweaking numpy tests. So, let's remove these tests? |
|
Removing the tests SGTM |
|
Either that, or modify them to use an int, either is fine really. |
cross-ref #87 (comment)