Basic ndarray.flags implementation
#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-br
reviewed
Feb 9, 2023
torch_np/_ndarray.py
Outdated
| if flag_to_value["C_CONTIGUOUS"]: | ||
| # There's no proper way to determine if a tensor is Fortran-style | ||
| # contiguous in torch, but at least we know it isn't when it is | ||
| # C-style. |
There was a problem hiding this comment.
Strictly speaking, 1D arrays can be both C and F contiguous. Not sure how deep into that rabbit hole we need fall though.
There was a problem hiding this comment.
Oh right—this was a bit magical to begin with so removed.
|
LET'S, so let's get this in to keep the ball rolling. Thanks @honno |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
x.flags, which mostly raisesNotImplementedError(). Seemed nice if just for porting NumPy's own tests.