Refactor pre commit #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move dealing with tensors to to _detail._reductions
A drawback of the current version is that the out=... arg needs to be passed as a keyword argument, and it cannot be a positional arg.
decorators in decorators.py know about arrays, _detail does not.
Also mimic numpy, which casts inputs to inexact types (pytorch raises if dtypes differ).
Fuse logical ops in normalize_axis_index Co-authored-by: Mario Lezcano Casado <[email protected]>
ev-br
force-pushed
the
refactor_pre_commit
branch
from
3f9f18f to
d7ce8d4
Compare
|
OK, this is annoying. Still does not work. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is gh-22 on top of main with all the pre-commit niceties. Am going to see if tests pass and merge if they are.