ENH: control a random stream to be from either numpy or pytorch #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a global switch to select the random stream origin: pytorch or numpy. If it's numpy, `tnp.random.uniform` just call `numpy.random.uniform` etc.
lezcano
approved these changes
May 10, 2023
|
You can also now use this flag in the E2E tests. |
|
Merged as approved, e2e testing will do separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a global switch to select the random stream origin: pytorch or numpy. If points to NumPy,
tnp.random.uniformjust callsnumpy.random.uniformetc.