Fixes and minors #129
Merged
Fixes and minors #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll move the reductions out of |
Don't use out= explicitly, improved a bit the implementation of `average`. Minor improvements here and there e.g. - prefer flatten over ravel as it's more PyTorch-y - Prefer `.double()` or `.long()` over `to(float)` (I didn't even know that worked...) for the same reason - Don't call .item() if we can avoid it (added to the list of differences) - remove _mappings - remove the need of semi_private methods - Fixed ndarray.fill, as the normalizer was not working because of the future annotations
ev-br
approved these changes
Apr 27, 2023
torch_np/_util.py
Outdated
| """Ravel the arrays if axis is none.""" | ||
| # XXX: is only used at `concatenate` and cumsum/cumprod. Inline unless reused more widely | ||
| def axis_none_flatten(*tensors, axis=None): | ||
| """Flatten the arrays if axis is None else normalize the axis.""" |
There was a problem hiding this comment.
Nit does not normalize the axis.
There was a problem hiding this comment.
Sorry, I was trying something else here but I didn't like it in the end. Forgot to update the comment
I don't see it in #73, is this where you meant to add it ? |
|
Yes, I added it, but after some editing I guess it was deleted along with the line about lists and tuples. This is fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements here and there e.g.
.double()or.long()overto(float)(I didn't even know that worked...) for the same reasonaverage.