Skip to content

MAINT: handle not implemented arguments centrally, via a dedicated annotation #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2023
Merged

MAINT: handle not implemented arguments centrally, via a dedicated annotation #114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64213f7
MAINT: handle not implemented arguments centrally, via a special anno…
ev-br Apr 16, 2023
1c80005
MAINT: use NotImplementedType not NotImplemented
ev-br Apr 17, 2023
ed292ed
MAINT: ufuncs: apply normalizations at decoration time not vars()[nam…
ev-br Apr 17, 2023
e2bd8d9
MAINT: nuke NoValue
ev-br Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 3 additions & 36 deletions torch_np/_detail/_reductions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@ def argmin(tensor, axis=None):
@emulate_keepdims
@deco_axis_expand
def any(tensor, axis=None, *, where=NoValue):
if where is not NoValue:
raise NotImplementedError

axis = _util.allow_only_single_axis(axis)

if axis is None:
Expand All @@ -149,9 +146,6 @@ def any(tensor, axis=None, *, where=NoValue):
@emulate_keepdims
@deco_axis_expand
def all(tensor, axis=None, *, where=NoValue):
if where is not NoValue:
raise NotImplementedError

axis = _util.allow_only_single_axis(axis)

if axis is None:
Expand All @@ -164,36 +158,24 @@ def all(tensor, axis=None, *, where=NoValue):
@emulate_keepdims
@deco_axis_expand
def max(tensor, axis=None, initial=NoValue, where=NoValue):
if initial is not NoValue or where is not NoValue:
raise NotImplementedError

result = tensor.amax(axis)
return result
return tensor.amax(axis)


@emulate_keepdims
@deco_axis_expand
def min(tensor, axis=None, initial=NoValue, where=NoValue):
if initial is not NoValue or where is not NoValue:
raise NotImplementedError

result = tensor.amin(axis)
return result
return tensor.amin(axis)


@emulate_keepdims
@deco_axis_expand
def ptp(tensor, axis=None):
result = tensor.amax(axis) - tensor.amin(axis)
return result
return tensor.amax(axis) - tensor.amin(axis)


@emulate_keepdims
@deco_axis_expand
def sum(tensor, axis=None, dtype=None, initial=NoValue, where=NoValue):
if initial is not NoValue or where is not NoValue:
raise NotImplementedError

assert dtype is None or isinstance(dtype, torch.dtype)

if dtype == torch.bool:
Expand All @@ -210,9 +192,6 @@ def sum(tensor, axis=None, dtype=None, initial=NoValue, where=NoValue):
@emulate_keepdims
@deco_axis_expand
def prod(tensor, axis=None, dtype=None, initial=NoValue, where=NoValue):
if initial is not NoValue or where is not NoValue:
raise NotImplementedError

axis = _util.allow_only_single_axis(axis)

if dtype == torch.bool:
Expand All @@ -229,9 +208,6 @@ def prod(tensor, axis=None, dtype=None, initial=NoValue, where=NoValue):
@emulate_keepdims
@deco_axis_expand
def mean(tensor, axis=None, dtype=None, *, where=NoValue):
if where is not NoValue:
raise NotImplementedError

dtype = _atleast_float(dtype, tensor.dtype)

is_half = dtype == torch.float16
Expand All @@ -253,9 +229,6 @@ def mean(tensor, axis=None, dtype=None, *, where=NoValue):
@emulate_keepdims
@deco_axis_expand
def std(tensor, axis=None, dtype=None, ddof=0, *, where=NoValue):
if where is not NoValue:
raise NotImplementedError

dtype = _atleast_float(dtype, tensor.dtype)
tensor = _util.cast_if_needed(tensor, dtype)
result = tensor.std(dim=axis, correction=ddof)
Expand All @@ -266,9 +239,6 @@ def std(tensor, axis=None, dtype=None, ddof=0, *, where=NoValue):
@emulate_keepdims
@deco_axis_expand
def var(tensor, axis=None, dtype=None, ddof=0, *, where=NoValue):
if where is not NoValue:
raise NotImplementedError

dtype = _atleast_float(dtype, tensor.dtype)
tensor = _util.cast_if_needed(tensor, dtype)
result = tensor.var(dim=axis, correction=ddof)
Expand Down Expand Up @@ -387,9 +357,6 @@ def quantile(
# Here we choose to work out-of-place because why not.
pass

if interpolation is not None:
raise ValueError("'interpolation' argument is deprecated; use 'method' instead")

if not a.dtype.is_floating_point:
dtype = _dtypes_impl.default_float_dtype
a = a.to(dtype)
Expand Down
Loading