Skip to content
This repository was archived by the owner on Nov 20, 2021. It is now read-only.

CatManga search is broken #9

Closed
IntermittentlyRupert opened this issue Sep 12, 2021 · 2 comments · Fixed by #10
Closed

CatManga search is broken #9

IntermittentlyRupert opened this issue Sep 12, 2021 · 2 comments · Fixed by #10

Comments

@IntermittentlyRupert
Copy link
Contributor

Any search on the CatManga source generates a JSError TypeError notification and no search results are shown.

Manga can still be added from the Discover and Library tabs - it seems to only be search that's broken..

Exported source logs (click to expand) 
[INFO] [2021-09-12T04:57:59.481Z] [JavaScriptModel:init(for:mainFileLocation:):59] Injected Logger
[INFO] [2021-09-12T04:57:59.495Z] [SourceModel:injectTypes():38] Registered 31 Types
[INFO] [2021-09-12T04:57:59.497Z] [JavaScriptModel:init(for:mainFileLocation:):61] Injected Types
[INFO] [2021-09-12T04:57:59.501Z] [JavaScriptModel:injectTypeWrappers():112] Registered 40 Type Wrappers
[INFO] [2021-09-12T04:57:59.506Z] [JavaScriptModel:init(for:mainFileLocation:):63] Injected Type Wrappers
[INFO] [2021-09-12T04:57:59.510Z] [JavaScriptModel:init(for:mainFileLocation:):65] Injected App Constants
[INFO] [2021-09-12T04:57:59.642Z] [JavaScriptModel:initialiseExtension():125] Injected Cheerio.js - 0.22.0
[INFO] [2021-09-12T04:57:59.646Z] [JavaScriptModel:initialiseExtension():129] Injected source.CatManga.js
[INFO] [2021-09-12T04:57:59.647Z] [JavaScriptModel:init(for:mainFileLocation:):67] Initialised Extension: CatManga - 1.2.9 by PythonCoderAS
[ERROR] [2021-09-12T04:58:08.090Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[INFO] [2021-09-12T04:58:41.839Z] [JavaScriptModel:init(for:mainFileLocation:):59] Injected Logger
[INFO] [2021-09-12T04:58:41.851Z] [SourceModel:injectTypes():38] Registered 31 Types
[INFO] [2021-09-12T04:58:41.854Z] [JavaScriptModel:init(for:mainFileLocation:):61] Injected Types
[INFO] [2021-09-12T04:58:41.858Z] [JavaScriptModel:injectTypeWrappers():112] Registered 40 Type Wrappers
[INFO] [2021-09-12T04:58:41.859Z] [JavaScriptModel:init(for:mainFileLocation:):63] Injected Type Wrappers
[INFO] [2021-09-12T04:58:41.860Z] [JavaScriptModel:init(for:mainFileLocation:):65] Injected App Constants
[INFO] [2021-09-12T04:58:42.002Z] [JavaScriptModel:initialiseExtension():125] Injected Cheerio.js - 0.22.0
[INFO] [2021-09-12T04:58:42.008Z] [JavaScriptModel:initialiseExtension():129] Injected source.CatManga.js
[INFO] [2021-09-12T04:58:42.011Z] [JavaScriptModel:init(for:mainFileLocation:):67] Initialised Extension: CatManga - 1.2.9 by PythonCoderAS
[ERROR] [2021-09-12T04:58:50.931Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T04:59:23.801Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T04:59:25.260Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T04:59:25.981Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T04:59:26.722Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T04:59:47.860Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T04:59:48.758Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T05:00:09.623Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T05:00:10.714Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T05:00:13.116Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T05:00:28.697Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T05:00:30.102Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T05:00:33.868Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[ERROR] [2021-09-12T05:00:34.609Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[INFO] [2021-09-12T05:02:57.954Z] [JavaScriptModel:init(for:mainFileLocation:):59] Injected Logger
[INFO] [2021-09-12T05:02:57.966Z] [SourceModel:injectTypes():38] Registered 31 Types
[INFO] [2021-09-12T05:02:57.967Z] [JavaScriptModel:init(for:mainFileLocation:):61] Injected Types
[INFO] [2021-09-12T05:02:57.971Z] [JavaScriptModel:injectTypeWrappers():112] Registered 40 Type Wrappers
[INFO] [2021-09-12T05:02:57.974Z] [JavaScriptModel:init(for:mainFileLocation:):63] Injected Type Wrappers
[INFO] [2021-09-12T05:02:57.978Z] [JavaScriptModel:init(for:mainFileLocation:):65] Injected App Constants
[INFO] [2021-09-12T05:02:58.131Z] [JavaScriptModel:initialiseExtension():125] Injected Cheerio.js - 0.22.0
[INFO] [2021-09-12T05:02:58.134Z] [JavaScriptModel:initialiseExtension():129] Injected source.CatManga.js
[INFO] [2021-09-12T05:02:58.136Z] [JavaScriptModel:init(for:mainFileLocation:):67] Initialised Extension: CatManga - 1.2.9 by PythonCoderAS
[ERROR] [2021-09-12T05:03:02.614Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[INFO] [2021-09-12T06:06:59.178Z] [JavaScriptModel:init(for:mainFileLocation:):59] Injected Logger
[INFO] [2021-09-12T06:06:59.196Z] [SourceModel:injectTypes():38] Registered 31 Types
[INFO] [2021-09-12T06:06:59.200Z] [JavaScriptModel:init(for:mainFileLocation:):61] Injected Types
[INFO] [2021-09-12T06:06:59.207Z] [JavaScriptModel:injectTypeWrappers():112] Registered 40 Type Wrappers
[INFO] [2021-09-12T06:06:59.214Z] [JavaScriptModel:init(for:mainFileLocation:):63] Injected Type Wrappers
[INFO] [2021-09-12T06:06:59.220Z] [JavaScriptModel:init(for:mainFileLocation:):65] Injected App Constants
[INFO] [2021-09-12T06:06:59.374Z] [JavaScriptModel:initialiseExtension():125] Injected Cheerio.js - 0.22.0
[INFO] [2021-09-12T06:06:59.377Z] [JavaScriptModel:initialiseExtension():129] Injected source.CatManga.js
[INFO] [2021-09-12T06:06:59.379Z] [JavaScriptModel:init(for:mainFileLocation:):67] Initialised Extension: CatManga - 1.2.9 by PythonCoderAS
[ERROR] [2021-09-12T06:07:11.813Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
[INFO] [2021-09-12T07:22:38.916Z] [JavaScriptModel:init(for:mainFileLocation:):59] Injected Logger
[INFO] [2021-09-12T07:22:38.933Z] [SourceModel:injectTypes():38] Registered 31 Types
[INFO] [2021-09-12T07:22:38.937Z] [JavaScriptModel:init(for:mainFileLocation:):61] Injected Types
[INFO] [2021-09-12T07:22:38.947Z] [JavaScriptModel:injectTypeWrappers():112] Registered 40 Type Wrappers
[INFO] [2021-09-12T07:22:38.950Z] [JavaScriptModel:init(for:mainFileLocation:):63] Injected Type Wrappers
[INFO] [2021-09-12T07:22:38.952Z] [JavaScriptModel:init(for:mainFileLocation:):65] Injected App Constants
[INFO] [2021-09-12T07:22:39.175Z] [JavaScriptModel:initialiseExtension():125] Injected Cheerio.js - 0.22.0
[INFO] [2021-09-12T07:22:39.183Z] [JavaScriptModel:initialiseExtension():129] Injected source.CatManga.js
[INFO] [2021-09-12T07:22:39.186Z] [JavaScriptModel:init(for:mainFileLocation:):67] Initialised Extension: CatManga - 1.2.9 by PythonCoderAS
[ERROR] [2021-09-12T07:23:29.198Z] [SourceModelImplementation:searchResults(for:metadata:):31] JSError TypeError JSError TypeError
  • Paperback v0.6.0-r2.0.13 (Public TestFlight)
  • CatManga source v1.2.9
@IntermittentlyRupert
Copy link
Contributor Author

IntermittentlyRupert commented Sep 12, 2021 •
edited
Loading

Everything looks fine and matches the interface definitions/official extension implementations when I log the objects returned in the unit tests, so I'm not totally sure where it's coming from. 🤷

EDIT: Did some debugging and it looks like SearchRequest#title is now immutable, so when CatManga#searchRequest tries to assign the sanitised search title back to the query, it throws. Looks like it might be a shared native object, because there's no message on the Error (which is why we get that very unhelpful notification) and this is the stack:

@
generatorResume@[native code]
fulfilled@
promiseReactionJob@[native code]

Easy fix. I'll make a PR.

Merged
@PythonCoderAS
Copy link
Owner

Thank you very much, I was having trouble finding out the true cause of the error. The test suite needs to be updated to follow these new rules.

PythonCoderAS added a commit that referenced this issue Sep 12, 2021
@PythonCoderAS
Merge pull request #10 from IntermittentlyRupert/fix/9-catmanga-search
30cce1d 
fix(catmanga): SearchRequest is now immutable (#9)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(catmanga): SearchRequest is now immutable (#9)
2 participants
@IntermittentlyRupert @PythonCoderAS